* [PATCH v2] kbuild: rewrite check-local-export in sh/awk
@ 2022-08-12 14:18 Owen Rafferty
2022-08-14 0:23 ` Masahiro Yamada
2022-08-27 14:01 ` Masahiro Yamada
0 siblings, 2 replies; 15+ messages in thread
From: Owen Rafferty @ 2022-08-12 14:18 UTC (permalink / raw)
To: linux-kbuild; +Cc: masahiroy
Remove the bash build dependency for those who otherwise do not
have it installed. This also provides a significant speedup:
$ make defconfig
$ make yes2modconfig
...
$ find . -name "*.o" | grep -v vmlinux | wc
3169 3169 89615
$ export NM=nm
$ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1
./scripts/check-local-export'
Without patch:
0m15.90s real 0m12.17s user 0m05.28s system
With patch:
dash + nawk
0m02.16s real 0m02.92s user 0m00.34s system
dash + busybox awk
0m02.36s real 0m03.36s user 0m00.34s system
dash + gawk
0m02.07s real 0m03.26s user 0m00.32s system
bash + gawk
0m03.55s real 0m05.00s user 0m00.54s system
Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
---
Notes:
[v2] commit message updated
scripts/check-local-export | 95 ++++++++++++++++++--------------------
1 file changed, 46 insertions(+), 49 deletions(-)
diff --git a/scripts/check-local-export b/scripts/check-local-export
index 6ccc2f467416..67eaa7cf08c0 100755
--- a/scripts/check-local-export
+++ b/scripts/check-local-export
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/bin/sh
# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
@@ -8,19 +8,6 @@
set -e
-# catch errors from ${NM}
-set -o pipefail
-
-# Run the last element of a pipeline in the current shell.
-# Without this, the while-loop would be executed in a subshell, and
-# the changes made to 'symbol_types' and 'export_symbols' would be lost.
-shopt -s lastpipe
-
-declare -A symbol_types
-declare -a export_symbols
-
-exit_code=0
-
# If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
# 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
# '2>/dev/null'. However, it suppresses real error messages as well. Add a
@@ -29,43 +16,53 @@ exit_code=0
# TODO:
# Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
# binutils to 2.37, llvm to 13.0.0.
-# Then, the following line will be really simple:
-# ${NM} --quiet ${1} |
+# Then, the following line will be simpler:
+# { ${NM} --quiet ${1} || kill 0; } |
+
+{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
+awk -v "file=${1}" '
+BEGIN {
+ exit_code = 0
+ i = 0
+}
+
+# Skip the line if the number of fields is less than 3.
+#
+# case 1)
+# For undefined symbols, the first field (value) is empty.
+# The outout looks like this:
+# " U _printk"
+# It is unneeded to record undefined symbols.
+#
+# case 2)
+# For Clang LTO, llvm-nm outputs a line with type t but empty name:
+# "---------------- t"
+!length($3) {
+ next
+}
-{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
-while read value type name
-do
- # Skip the line if the number of fields is less than 3.
- #
- # case 1)
- # For undefined symbols, the first field (value) is empty.
- # The outout looks like this:
- # " U _printk"
- # It is unneeded to record undefined symbols.
- #
- # case 2)
- # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
- # "---------------- t"
- if [[ -z ${name} ]]; then
- continue
- fi
+# save (name, type) in the associative array
+{ symbol_types[$3]=$2 }
- # save (name, type) in the associative array
- symbol_types[${name}]=${type}
+# append the exported symbol to the array
+($3 ~ /^__ksymtab_/) {
+ export_symbols[i] = $3
+ sub(/^__ksymtab_/, "", export_symbols[i])
+ i++
+}
- # append the exported symbol to the array
- if [[ ${name} == __ksymtab_* ]]; then
- export_symbols+=(${name#__ksymtab_})
- fi
-done
+END {
+ for (j = 0; j < i; ++j) {
+ name = export_symbols[j]
+ # nm(3) says "If lowercase, the symbol is usually local"
+ if (symbol_types[name] ~ /[a-z]/) {
+ printf "%s: error: local symbol %s was exported\n",
+ file, name | "cat 1>&2"
+ exit_code = 1
+ }
+ }
-for name in "${export_symbols[@]}"
-do
- # nm(3) says "If lowercase, the symbol is usually local"
- if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
- echo "$@: error: local symbol '${name}' was exported" >&2
- exit_code=1
- fi
-done
+ exit exit_code
+}'
-exit ${exit_code}
+exit $?
--
2.37.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v2] kbuild: rewrite check-local-export in sh/awk
2022-08-12 14:18 [PATCH v2] kbuild: rewrite check-local-export in sh/awk Owen Rafferty
@ 2022-08-14 0:23 ` Masahiro Yamada
2022-08-15 0:25 ` Owen Rafferty
2022-08-27 14:01 ` Masahiro Yamada
1 sibling, 1 reply; 15+ messages in thread
From: Masahiro Yamada @ 2022-08-14 0:23 UTC (permalink / raw)
To: Owen Rafferty; +Cc: Linux Kbuild mailing list
On Fri, Aug 12, 2022 at 11:36 PM Owen Rafferty <owen@owenrafferty.com> wrote:
>
> Remove the bash build dependency for those who otherwise do not
> have it installed. This also provides a significant speedup:
>
> $ make defconfig
> $ make yes2modconfig
>
> ...
>
> $ find . -name "*.o" | grep -v vmlinux | wc
> 3169 3169 89615
> $ export NM=nm
> $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1
> ./scripts/check-local-export'
>
> Without patch:
> 0m15.90s real 0m12.17s user 0m05.28s system
>
> With patch:
> dash + nawk
> 0m02.16s real 0m02.92s user 0m00.34s system
>
> dash + busybox awk
> 0m02.36s real 0m03.36s user 0m00.34s system
>
> dash + gawk
> 0m02.07s real 0m03.26s user 0m00.32s system
>
> bash + gawk
> 0m03.55s real 0m05.00s user 0m00.54s system
>
> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
How did you get those small numbers?
The script invokes ${NM} internally,
so it is impossible to become faster than nm.
For me, it takes 55 sec just for running nm.
$ find . -name "*.o" | wc
3191 3191 90085
$ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm >/dev/null'
nm: ./arch/x86/entry/vdso/vdso32/note.o: no symbols
nm: ./arch/x86/entry/vdso/vdso-note.o: no symbols
real 0m55.783s
user 0m24.887s
sys 0m30.905s
> ---
>
> Notes:
> [v2] commit message updated
>
> scripts/check-local-export | 95 ++++++++++++++++++--------------------
> 1 file changed, 46 insertions(+), 49 deletions(-)
>
> diff --git a/scripts/check-local-export b/scripts/check-local-export
> index 6ccc2f467416..67eaa7cf08c0 100755
> --- a/scripts/check-local-export
> +++ b/scripts/check-local-export
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env bash
> +#!/bin/sh
> # SPDX-License-Identifier: GPL-2.0-only
> #
> # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
> @@ -8,19 +8,6 @@
>
> set -e
>
> -# catch errors from ${NM}
> -set -o pipefail
> -
> -# Run the last element of a pipeline in the current shell.
> -# Without this, the while-loop would be executed in a subshell, and
> -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
> -shopt -s lastpipe
> -
> -declare -A symbol_types
> -declare -a export_symbols
> -
> -exit_code=0
> -
> # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> # '2>/dev/null'. However, it suppresses real error messages as well. Add a
> @@ -29,43 +16,53 @@ exit_code=0
> # TODO:
> # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> # binutils to 2.37, llvm to 13.0.0.
> -# Then, the following line will be really simple:
> -# ${NM} --quiet ${1} |
> +# Then, the following line will be simpler:
> +# { ${NM} --quiet ${1} || kill 0; } |
> +
> +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> +awk -v "file=${1}" '
> +BEGIN {
> + exit_code = 0
> + i = 0
> +}
> +
> +# Skip the line if the number of fields is less than 3.
> +#
> +# case 1)
> +# For undefined symbols, the first field (value) is empty.
> +# The outout looks like this:
> +# " U _printk"
> +# It is unneeded to record undefined symbols.
> +#
> +# case 2)
> +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
> +# "---------------- t"
> +!length($3) {
> + next
> +}
>
> -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
> -while read value type name
> -do
> - # Skip the line if the number of fields is less than 3.
> - #
> - # case 1)
> - # For undefined symbols, the first field (value) is empty.
> - # The outout looks like this:
> - # " U _printk"
> - # It is unneeded to record undefined symbols.
> - #
> - # case 2)
> - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
> - # "---------------- t"
> - if [[ -z ${name} ]]; then
> - continue
> - fi
> +# save (name, type) in the associative array
> +{ symbol_types[$3]=$2 }
>
> - # save (name, type) in the associative array
> - symbol_types[${name}]=${type}
> +# append the exported symbol to the array
> +($3 ~ /^__ksymtab_/) {
> + export_symbols[i] = $3
> + sub(/^__ksymtab_/, "", export_symbols[i])
> + i++
> +}
>
> - # append the exported symbol to the array
> - if [[ ${name} == __ksymtab_* ]]; then
> - export_symbols+=(${name#__ksymtab_})
> - fi
> -done
> +END {
> + for (j = 0; j < i; ++j) {
> + name = export_symbols[j]
> + # nm(3) says "If lowercase, the symbol is usually local"
> + if (symbol_types[name] ~ /[a-z]/) {
> + printf "%s: error: local symbol %s was exported\n",
> + file, name | "cat 1>&2"
> + exit_code = 1
> + }
> + }
>
> -for name in "${export_symbols[@]}"
> -do
> - # nm(3) says "If lowercase, the symbol is usually local"
> - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
> - echo "$@: error: local symbol '${name}' was exported" >&2
> - exit_code=1
> - fi
> -done
> + exit exit_code
> +}'
>
> -exit ${exit_code}
> +exit $?
> --
> 2.37.2
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] kbuild: rewrite check-local-export in sh/awk
2022-08-14 0:23 ` Masahiro Yamada
@ 2022-08-15 0:25 ` Owen Rafferty
2022-08-27 5:40 ` Masahiro Yamada
0 siblings, 1 reply; 15+ messages in thread
From: Owen Rafferty @ 2022-08-15 0:25 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Linux Kbuild mailing list
On 22/08/14 09:23AM, Masahiro Yamada wrote:
> On Fri, Aug 12, 2022 at 11:36 PM Owen Rafferty <owen@owenrafferty.com> wrote:
> >
> > Remove the bash build dependency for those who otherwise do not
> > have it installed. This also provides a significant speedup:
> >
> > $ make defconfig
> > $ make yes2modconfig
> >
> > ...
> >
> > $ find . -name "*.o" | grep -v vmlinux | wc
> > 3169 3169 89615
> > $ export NM=nm
> > $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1
> > ./scripts/check-local-export'
> >
> > Without patch:
> > 0m15.90s real 0m12.17s user 0m05.28s system
> >
> > With patch:
> > dash + nawk
> > 0m02.16s real 0m02.92s user 0m00.34s system
> >
> > dash + busybox awk
> > 0m02.36s real 0m03.36s user 0m00.34s system
> >
> > dash + gawk
> > 0m02.07s real 0m03.26s user 0m00.32s system
> >
> > bash + gawk
> > 0m03.55s real 0m05.00s user 0m00.54s system
> >
> > Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
>
>
>
>
> How did you get those small numbers?
>
>
> The script invokes ${NM} internally,
> so it is impossible to become faster than nm.
>
> For me, it takes 55 sec just for running nm.
>
>
>
>
> $ find . -name "*.o" | wc
> 3191 3191 90085
>
> $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm >/dev/null'
> nm: ./arch/x86/entry/vdso/vdso32/note.o: no symbols
> nm: ./arch/x86/entry/vdso/vdso-note.o: no symbols
>
> real 0m55.783s
> user 0m24.887s
> sys 0m30.905s
>
I'm not exactly sure. I get compatible numbers with just nm.
$ find . -name "*.o" | grep -v vmlinux | wc
3169 3169 89615
$ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm'
0m02.02s real 0m01.77s user 0m00.43s system
> > ---
> >
> > Notes:
> > [v2] commit message updated
> >
> > scripts/check-local-export | 95 ++++++++++++++++++--------------------
> > 1 file changed, 46 insertions(+), 49 deletions(-)
> >
> > diff --git a/scripts/check-local-export b/scripts/check-local-export
> > index 6ccc2f467416..67eaa7cf08c0 100755
> > --- a/scripts/check-local-export
> > +++ b/scripts/check-local-export
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env bash
> > +#!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-only
> > #
> > # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
> > @@ -8,19 +8,6 @@
> >
> > set -e
> >
> > -# catch errors from ${NM}
> > -set -o pipefail
> > -
> > -# Run the last element of a pipeline in the current shell.
> > -# Without this, the while-loop would be executed in a subshell, and
> > -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
> > -shopt -s lastpipe
> > -
> > -declare -A symbol_types
> > -declare -a export_symbols
> > -
> > -exit_code=0
> > -
> > # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> > # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> > # '2>/dev/null'. However, it suppresses real error messages as well. Add a
> > @@ -29,43 +16,53 @@ exit_code=0
> > # TODO:
> > # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> > # binutils to 2.37, llvm to 13.0.0.
> > -# Then, the following line will be really simple:
> > -# ${NM} --quiet ${1} |
> > +# Then, the following line will be simpler:
> > +# { ${NM} --quiet ${1} || kill 0; } |
> > +
> > +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> > +awk -v "file=${1}" '
> > +BEGIN {
> > + exit_code = 0
> > + i = 0
> > +}
> > +
> > +# Skip the line if the number of fields is less than 3.
> > +#
> > +# case 1)
> > +# For undefined symbols, the first field (value) is empty.
> > +# The outout looks like this:
> > +# " U _printk"
> > +# It is unneeded to record undefined symbols.
> > +#
> > +# case 2)
> > +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
> > +# "---------------- t"
> > +!length($3) {
> > + next
> > +}
> >
> > -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
> > -while read value type name
> > -do
> > - # Skip the line if the number of fields is less than 3.
> > - #
> > - # case 1)
> > - # For undefined symbols, the first field (value) is empty.
> > - # The outout looks like this:
> > - # " U _printk"
> > - # It is unneeded to record undefined symbols.
> > - #
> > - # case 2)
> > - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
> > - # "---------------- t"
> > - if [[ -z ${name} ]]; then
> > - continue
> > - fi
> > +# save (name, type) in the associative array
> > +{ symbol_types[$3]=$2 }
> >
> > - # save (name, type) in the associative array
> > - symbol_types[${name}]=${type}
> > +# append the exported symbol to the array
> > +($3 ~ /^__ksymtab_/) {
> > + export_symbols[i] = $3
> > + sub(/^__ksymtab_/, "", export_symbols[i])
> > + i++
> > +}
> >
> > - # append the exported symbol to the array
> > - if [[ ${name} == __ksymtab_* ]]; then
> > - export_symbols+=(${name#__ksymtab_})
> > - fi
> > -done
> > +END {
> > + for (j = 0; j < i; ++j) {
> > + name = export_symbols[j]
> > + # nm(3) says "If lowercase, the symbol is usually local"
> > + if (symbol_types[name] ~ /[a-z]/) {
> > + printf "%s: error: local symbol %s was exported\n",
> > + file, name | "cat 1>&2"
> > + exit_code = 1
> > + }
> > + }
> >
> > -for name in "${export_symbols[@]}"
> > -do
> > - # nm(3) says "If lowercase, the symbol is usually local"
> > - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
> > - echo "$@: error: local symbol '${name}' was exported" >&2
> > - exit_code=1
> > - fi
> > -done
> > + exit exit_code
> > +}'
> >
> > -exit ${exit_code}
> > +exit $?
> > --
> > 2.37.2
> >
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] kbuild: rewrite check-local-export in sh/awk
2022-08-15 0:25 ` Owen Rafferty
@ 2022-08-27 5:40 ` Masahiro Yamada
0 siblings, 0 replies; 15+ messages in thread
From: Masahiro Yamada @ 2022-08-27 5:40 UTC (permalink / raw)
To: Owen Rafferty; +Cc: Linux Kbuild mailing list
On Mon, Aug 15, 2022 at 9:25 AM Owen Rafferty <owen@owenrafferty.com> wrote:
>
> On 22/08/14 09:23AM, Masahiro Yamada wrote:
> > On Fri, Aug 12, 2022 at 11:36 PM Owen Rafferty <owen@owenrafferty.com> wrote:
> > >
> > > Remove the bash build dependency for those who otherwise do not
> > > have it installed. This also provides a significant speedup:
> > >
> > > $ make defconfig
> > > $ make yes2modconfig
> > >
> > > ...
> > >
> > > $ find . -name "*.o" | grep -v vmlinux | wc
> > > 3169 3169 89615
> > > $ export NM=nm
> > > $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1
> > > ./scripts/check-local-export'
> > >
> > > Without patch:
> > > 0m15.90s real 0m12.17s user 0m05.28s system
> > >
> > > With patch:
> > > dash + nawk
> > > 0m02.16s real 0m02.92s user 0m00.34s system
> > >
> > > dash + busybox awk
> > > 0m02.36s real 0m03.36s user 0m00.34s system
> > >
> > > dash + gawk
> > > 0m02.07s real 0m03.26s user 0m00.32s system
> > >
> > > bash + gawk
> > > 0m03.55s real 0m05.00s user 0m00.54s system
> > >
> > > Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
> >
> >
> >
> >
> > How did you get those small numbers?
> >
> >
> > The script invokes ${NM} internally,
> > so it is impossible to become faster than nm.
> >
> > For me, it takes 55 sec just for running nm.
> >
> >
> >
> >
> > $ find . -name "*.o" | wc
> > 3191 3191 90085
> >
> > $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm >/dev/null'
> > nm: ./arch/x86/entry/vdso/vdso32/note.o: no symbols
> > nm: ./arch/x86/entry/vdso/vdso-note.o: no symbols
> >
> > real 0m55.783s
> > user 0m24.887s
> > sys 0m30.905s
> >
>
> I'm not exactly sure. I get compatible numbers with just nm.
>
> $ find . -name "*.o" | grep -v vmlinux | wc
> 3169 3169 89615
>
> $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm'
> 0m02.02s real 0m01.77s user 0m00.43s system
>
About the slowness of nm, it might depend on the GNU binutils version.
I tried some versions in docker.
On Ubuntu 18.04:
$ nm -V | head -n1
GNU nm (GNU Binutils for Ubuntu) 2.30
$ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm >/dev/null'
nm: ./arch/x86/entry/vdso/vdso-note.o: no symbols
nm: ./arch/x86/entry/vdso/vdso32/note.o: no symbols
real 0m2.694s
user 0m2.201s
sys 0m0.729s
On Ubuntu 20.04:
$ nm -V | head -n1
GNU nm (GNU Binutils for Ubuntu) 2.34
$ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm >/dev/null'
nm: ./arch/x86/entry/vdso/vdso-note.o: no symbols
nm: ./arch/x86/entry/vdso/vdso32/note.o: no symbols
real 0m5.287s
user 0m3.356s
sys 0m2.035s
On Ubuntu 22.04:
$ nm -V | head -n1
GNU nm (GNU Binutils for Ubuntu) 2.38
$ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1 nm >/dev/null'
nm: ./arch/x86/entry/vdso/vdso-note.o: no symbols
nm: ./arch/x86/entry/vdso/vdso32/note.o: no symbols
real 0m37.107s
user 0m14.121s
sys 0m23.229s
So, 'nm' is progressively becoming slower and slower.
With the recent nm, most of the time for running check-local-export
is consumed for 'nm'.
llvm-nm is a little faster, but it is still slow.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v2] kbuild: rewrite check-local-export in sh/awk
2022-08-12 14:18 [PATCH v2] kbuild: rewrite check-local-export in sh/awk Owen Rafferty
2022-08-14 0:23 ` Masahiro Yamada
@ 2022-08-27 14:01 ` Masahiro Yamada
2022-08-27 16:52 ` [PATCH v3] " Owen Rafferty
1 sibling, 1 reply; 15+ messages in thread
From: Masahiro Yamada @ 2022-08-27 14:01 UTC (permalink / raw)
To: Owen Rafferty; +Cc: Linux Kbuild mailing list
On Fri, Aug 12, 2022 at 11:36 PM Owen Rafferty <owen@owenrafferty.com> wrote:
>
> Remove the bash build dependency for those who otherwise do not
> have it installed. This also provides a significant speedup:
>
> $ make defconfig
> $ make yes2modconfig
>
> ...
>
> $ find . -name "*.o" | grep -v vmlinux | wc
> 3169 3169 89615
> $ export NM=nm
> $ time sh -c 'find . -name "*.o" | grep -v vmlinux | xargs -n1
> ./scripts/check-local-export'
>
> Without patch:
> 0m15.90s real 0m12.17s user 0m05.28s system
>
> With patch:
> dash + nawk
> 0m02.16s real 0m02.92s user 0m00.34s system
>
> dash + busybox awk
> 0m02.36s real 0m03.36s user 0m00.34s system
>
> dash + gawk
> 0m02.07s real 0m03.26s user 0m00.32s system
>
> bash + gawk
> 0m03.55s real 0m05.00s user 0m00.54s system
>
> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
> ---
>
> Notes:
> [v2] commit message updated
Anyway, awk seems to be faster than bash.
Can you send v3 with the following nits fixed?
Then, I will pick it up.
>
> scripts/check-local-export | 95 ++++++++++++++++++--------------------
> 1 file changed, 46 insertions(+), 49 deletions(-)
>
> diff --git a/scripts/check-local-export b/scripts/check-local-export
> index 6ccc2f467416..67eaa7cf08c0 100755
> --- a/scripts/check-local-export
> +++ b/scripts/check-local-export
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env bash
> +#!/bin/sh
> # SPDX-License-Identifier: GPL-2.0-only
> #
> # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
Now that you rewrote many parts of the code,
can you add your Copyright below mine?
> @@ -29,43 +16,53 @@ exit_code=0
> # TODO:
> # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> # binutils to 2.37, llvm to 13.0.0.
> -# Then, the following line will be really simple:
> -# ${NM} --quiet ${1} |
> +# Then, the following line will be simpler:
> +# { ${NM} --quiet ${1} || kill 0; } |
I am not a big fan of 'kill 0', but
I do not have a better idea to achieve pipefail in POSIX shell.
So, we can live with it.
> +
> +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> +awk -v "file=${1}" '
Can you use ${AWK} instead of 'awk' for consistency?
AWK is defined in the top Makefile.
> +BEGIN {
> + exit_code = 0
'exit_code' is only used in END,
so I think this initialization can go there.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v3] kbuild: rewrite check-local-export in sh/awk
2022-08-27 14:01 ` Masahiro Yamada
@ 2022-08-27 16:52 ` Owen Rafferty
2022-08-31 6:44 ` Masahiro Yamada
0 siblings, 1 reply; 15+ messages in thread
From: Owen Rafferty @ 2022-08-27 16:52 UTC (permalink / raw)
To: masahiroy; +Cc: linux-kbuild
---
scripts/check-local-export | 96 +++++++++++++++++++-------------------
1 file changed, 47 insertions(+), 49 deletions(-)
diff --git a/scripts/check-local-export b/scripts/check-local-export
index 6ccc2f467416..0c049ff44aca 100755
--- a/scripts/check-local-export
+++ b/scripts/check-local-export
@@ -1,26 +1,14 @@
-#!/usr/bin/env bash
+#!/bin/sh
# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
+# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
#
# Exit with error if a local exported symbol is found.
# EXPORT_SYMBOL should be used for global symbols.
set -e
-# catch errors from ${NM}
-set -o pipefail
-
-# Run the last element of a pipeline in the current shell.
-# Without this, the while-loop would be executed in a subshell, and
-# the changes made to 'symbol_types' and 'export_symbols' would be lost.
-shopt -s lastpipe
-
-declare -A symbol_types
-declare -a export_symbols
-
-exit_code=0
-
# If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
# 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
# '2>/dev/null'. However, it suppresses real error messages as well. Add a
@@ -29,43 +17,53 @@ exit_code=0
# TODO:
# Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
# binutils to 2.37, llvm to 13.0.0.
-# Then, the following line will be really simple:
-# ${NM} --quiet ${1} |
+# Then, the following line will be simpler:
+# { ${NM} --quiet ${1} || kill 0; } |
+
+{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
+${AWK} -v "file=${1}" '
+BEGIN {
+ i = 0
+}
+
+# Skip the line if the number of fields is less than 3.
+#
+# case 1)
+# For undefined symbols, the first field (value) is empty.
+# The outout looks like this:
+# " U _printk"
+# It is unneeded to record undefined symbols.
+#
+# case 2)
+# For Clang LTO, llvm-nm outputs a line with type t but empty name:
+# "---------------- t"
+!length($3) {
+ next
+}
-{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
-while read value type name
-do
- # Skip the line if the number of fields is less than 3.
- #
- # case 1)
- # For undefined symbols, the first field (value) is empty.
- # The outout looks like this:
- # " U _printk"
- # It is unneeded to record undefined symbols.
- #
- # case 2)
- # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
- # "---------------- t"
- if [[ -z ${name} ]]; then
- continue
- fi
+# save (name, type) in the associative array
+{ symbol_types[$3]=$2 }
- # save (name, type) in the associative array
- symbol_types[${name}]=${type}
+# append the exported symbol to the array
+($3 ~ /^__ksymtab_/) {
+ export_symbols[i] = $3
+ sub(/^__ksymtab_/, "", export_symbols[i])
+ i++
+}
- # append the exported symbol to the array
- if [[ ${name} == __ksymtab_* ]]; then
- export_symbols+=(${name#__ksymtab_})
- fi
-done
+END {
+ exit_code = 0
+ for (j = 0; j < i; ++j) {
+ name = export_symbols[j]
+ # nm(3) says "If lowercase, the symbol is usually local"
+ if (symbol_types[name] ~ /[a-z]/) {
+ printf "%s: error: local symbol %s was exported\n",
+ file, name | "cat 1>&2"
+ exit_code = 1
+ }
+ }
-for name in "${export_symbols[@]}"
-do
- # nm(3) says "If lowercase, the symbol is usually local"
- if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
- echo "$@: error: local symbol '${name}' was exported" >&2
- exit_code=1
- fi
-done
+ exit exit_code
+}'
-exit ${exit_code}
+exit $?
--
2.37.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3] kbuild: rewrite check-local-export in sh/awk
2022-08-27 16:52 ` [PATCH v3] " Owen Rafferty
@ 2022-08-31 6:44 ` Masahiro Yamada
2022-08-31 20:57 ` [PATCH v4] " Owen Rafferty
2022-08-31 21:03 ` [PATCH v3] " Owen Rafferty
0 siblings, 2 replies; 15+ messages in thread
From: Masahiro Yamada @ 2022-08-31 6:44 UTC (permalink / raw)
To: Owen Rafferty; +Cc: Linux Kbuild mailing list
On Mon, Aug 29, 2022 at 8:57 AM Owen Rafferty <owen@owenrafferty.com> wrote:
>
> ---
> scripts/check-local-export | 96 +++++++++++++++++++-------------------
> 1 file changed, 47 insertions(+), 49 deletions(-)
V3 improved the code, but the entire commit log disappeared.
I guess it is by accident.
v2:
https://patchwork.kernel.org/project/linux-kbuild/patch/a2ccf1338513f3a2250cd0a9fe5894f83ce3e4a7.1660314650.git.owen@owenrafferty.com/
v3:
https://patchwork.kernel.org/project/linux-kbuild/patch/0e70974912f6b2cd95a18192418a438f9c57f690.1661730960.git.owen@owenrafferty.com/
Do you want me to restore the log from v2?
> diff --git a/scripts/check-local-export b/scripts/check-local-export
> index 6ccc2f467416..0c049ff44aca 100755
> --- a/scripts/check-local-export
> +++ b/scripts/check-local-export
> @@ -1,26 +1,14 @@
> -#!/usr/bin/env bash
> +#!/bin/sh
> # SPDX-License-Identifier: GPL-2.0-only
> #
> # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
> +# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
> #
> # Exit with error if a local exported symbol is found.
> # EXPORT_SYMBOL should be used for global symbols.
>
> set -e
>
> -# catch errors from ${NM}
> -set -o pipefail
> -
> -# Run the last element of a pipeline in the current shell.
> -# Without this, the while-loop would be executed in a subshell, and
> -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
> -shopt -s lastpipe
> -
> -declare -A symbol_types
> -declare -a export_symbols
> -
> -exit_code=0
> -
> # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> # '2>/dev/null'. However, it suppresses real error messages as well. Add a
> @@ -29,43 +17,53 @@ exit_code=0
> # TODO:
> # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> # binutils to 2.37, llvm to 13.0.0.
> -# Then, the following line will be really simple:
> -# ${NM} --quiet ${1} |
> +# Then, the following line will be simpler:
> +# { ${NM} --quiet ${1} || kill 0; } |
> +
> +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> +${AWK} -v "file=${1}" '
> +BEGIN {
> + i = 0
> +}
> +
> +# Skip the line if the number of fields is less than 3.
> +#
> +# case 1)
> +# For undefined symbols, the first field (value) is empty.
> +# The outout looks like this:
> +# " U _printk"
> +# It is unneeded to record undefined symbols.
> +#
> +# case 2)
> +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
> +# "---------------- t"
> +!length($3) {
> + next
> +}
>
> -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
> -while read value type name
> -do
> - # Skip the line if the number of fields is less than 3.
> - #
> - # case 1)
> - # For undefined symbols, the first field (value) is empty.
> - # The outout looks like this:
> - # " U _printk"
> - # It is unneeded to record undefined symbols.
> - #
> - # case 2)
> - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
> - # "---------------- t"
> - if [[ -z ${name} ]]; then
> - continue
> - fi
> +# save (name, type) in the associative array
> +{ symbol_types[$3]=$2 }
>
> - # save (name, type) in the associative array
> - symbol_types[${name}]=${type}
> +# append the exported symbol to the array
> +($3 ~ /^__ksymtab_/) {
> + export_symbols[i] = $3
> + sub(/^__ksymtab_/, "", export_symbols[i])
> + i++
> +}
>
> - # append the exported symbol to the array
> - if [[ ${name} == __ksymtab_* ]]; then
> - export_symbols+=(${name#__ksymtab_})
> - fi
> -done
> +END {
> + exit_code = 0
> + for (j = 0; j < i; ++j) {
> + name = export_symbols[j]
> + # nm(3) says "If lowercase, the symbol is usually local"
> + if (symbol_types[name] ~ /[a-z]/) {
> + printf "%s: error: local symbol %s was exported\n",
> + file, name | "cat 1>&2"
> + exit_code = 1
> + }
> + }
>
> -for name in "${export_symbols[@]}"
> -do
> - # nm(3) says "If lowercase, the symbol is usually local"
> - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
> - echo "$@: error: local symbol '${name}' was exported" >&2
> - exit_code=1
> - fi
> -done
> + exit exit_code
> +}'
>
> -exit ${exit_code}
> +exit $?
> --
> 2.37.2
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-08-31 6:44 ` Masahiro Yamada
@ 2022-08-31 20:57 ` Owen Rafferty
2022-09-03 16:01 ` Masahiro Yamada
2022-08-31 21:03 ` [PATCH v3] " Owen Rafferty
1 sibling, 1 reply; 15+ messages in thread
From: Owen Rafferty @ 2022-08-31 20:57 UTC (permalink / raw)
To: masahiroy; +Cc: linux-kbuild
Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
---
scripts/check-local-export | 96 +++++++++++++++++++-------------------
1 file changed, 47 insertions(+), 49 deletions(-)
diff --git a/scripts/check-local-export b/scripts/check-local-export
index 6ccc2f467416..0c049ff44aca 100755
--- a/scripts/check-local-export
+++ b/scripts/check-local-export
@@ -1,26 +1,14 @@
-#!/usr/bin/env bash
+#!/bin/sh
# SPDX-License-Identifier: GPL-2.0-only
#
# Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
+# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
#
# Exit with error if a local exported symbol is found.
# EXPORT_SYMBOL should be used for global symbols.
set -e
-# catch errors from ${NM}
-set -o pipefail
-
-# Run the last element of a pipeline in the current shell.
-# Without this, the while-loop would be executed in a subshell, and
-# the changes made to 'symbol_types' and 'export_symbols' would be lost.
-shopt -s lastpipe
-
-declare -A symbol_types
-declare -a export_symbols
-
-exit_code=0
-
# If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
# 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
# '2>/dev/null'. However, it suppresses real error messages as well. Add a
@@ -29,43 +17,53 @@ exit_code=0
# TODO:
# Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
# binutils to 2.37, llvm to 13.0.0.
-# Then, the following line will be really simple:
-# ${NM} --quiet ${1} |
+# Then, the following line will be simpler:
+# { ${NM} --quiet ${1} || kill 0; } |
+
+{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
+${AWK} -v "file=${1}" '
+BEGIN {
+ i = 0
+}
+
+# Skip the line if the number of fields is less than 3.
+#
+# case 1)
+# For undefined symbols, the first field (value) is empty.
+# The outout looks like this:
+# " U _printk"
+# It is unneeded to record undefined symbols.
+#
+# case 2)
+# For Clang LTO, llvm-nm outputs a line with type t but empty name:
+# "---------------- t"
+!length($3) {
+ next
+}
-{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
-while read value type name
-do
- # Skip the line if the number of fields is less than 3.
- #
- # case 1)
- # For undefined symbols, the first field (value) is empty.
- # The outout looks like this:
- # " U _printk"
- # It is unneeded to record undefined symbols.
- #
- # case 2)
- # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
- # "---------------- t"
- if [[ -z ${name} ]]; then
- continue
- fi
+# save (name, type) in the associative array
+{ symbol_types[$3]=$2 }
- # save (name, type) in the associative array
- symbol_types[${name}]=${type}
+# append the exported symbol to the array
+($3 ~ /^__ksymtab_/) {
+ export_symbols[i] = $3
+ sub(/^__ksymtab_/, "", export_symbols[i])
+ i++
+}
- # append the exported symbol to the array
- if [[ ${name} == __ksymtab_* ]]; then
- export_symbols+=(${name#__ksymtab_})
- fi
-done
+END {
+ exit_code = 0
+ for (j = 0; j < i; ++j) {
+ name = export_symbols[j]
+ # nm(3) says "If lowercase, the symbol is usually local"
+ if (symbol_types[name] ~ /[a-z]/) {
+ printf "%s: error: local symbol %s was exported\n",
+ file, name | "cat 1>&2"
+ exit_code = 1
+ }
+ }
-for name in "${export_symbols[@]}"
-do
- # nm(3) says "If lowercase, the symbol is usually local"
- if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
- echo "$@: error: local symbol '${name}' was exported" >&2
- exit_code=1
- fi
-done
+ exit exit_code
+}'
-exit ${exit_code}
+exit $?
--
2.37.3
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v3] kbuild: rewrite check-local-export in sh/awk
2022-08-31 6:44 ` Masahiro Yamada
2022-08-31 20:57 ` [PATCH v4] " Owen Rafferty
@ 2022-08-31 21:03 ` Owen Rafferty
1 sibling, 0 replies; 15+ messages in thread
From: Owen Rafferty @ 2022-08-31 21:03 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild
On 22/08/31 03:44PM, Masahiro Yamada wrote:
> On Mon, Aug 29, 2022 at 8:57 AM Owen Rafferty <owen@owenrafferty.com> wrote:
> >
> > ---
> > scripts/check-local-export | 96 +++++++++++++++++++-------------------
> > 1 file changed, 47 insertions(+), 49 deletions(-)
>
>
>
>
> V3 improved the code, but the entire commit log disappeared.
> I guess it is by accident.
>
>
>
> v2:
> https://patchwork.kernel.org/project/linux-kbuild/patch/a2ccf1338513f3a2250cd0a9fe5894f83ce3e4a7.1660314650.git.owen@owenrafferty.com/
>
> v3:
> https://patchwork.kernel.org/project/linux-kbuild/patch/0e70974912f6b2cd95a18192418a438f9c57f690.1661730960.git.owen@owenrafferty.com/
>
>
>
> Do you want me to restore the log from v2?
>
I'll submit v4, applied atop your kbuild branch and with a proper
signoff. Thanks for bearing with me.
>
> > diff --git a/scripts/check-local-export b/scripts/check-local-export
> > index 6ccc2f467416..0c049ff44aca 100755
> > --- a/scripts/check-local-export
> > +++ b/scripts/check-local-export
> > @@ -1,26 +1,14 @@
> > -#!/usr/bin/env bash
> > +#!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-only
> > #
> > # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
> > +# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
> > #
> > # Exit with error if a local exported symbol is found.
> > # EXPORT_SYMBOL should be used for global symbols.
> >
> > set -e
> >
> > -# catch errors from ${NM}
> > -set -o pipefail
> > -
> > -# Run the last element of a pipeline in the current shell.
> > -# Without this, the while-loop would be executed in a subshell, and
> > -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
> > -shopt -s lastpipe
> > -
> > -declare -A symbol_types
> > -declare -a export_symbols
> > -
> > -exit_code=0
> > -
> > # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> > # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> > # '2>/dev/null'. However, it suppresses real error messages as well. Add a
> > @@ -29,43 +17,53 @@ exit_code=0
> > # TODO:
> > # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> > # binutils to 2.37, llvm to 13.0.0.
> > -# Then, the following line will be really simple:
> > -# ${NM} --quiet ${1} |
> > +# Then, the following line will be simpler:
> > +# { ${NM} --quiet ${1} || kill 0; } |
> > +
> > +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> > +${AWK} -v "file=${1}" '
> > +BEGIN {
> > + i = 0
> > +}
> > +
> > +# Skip the line if the number of fields is less than 3.
> > +#
> > +# case 1)
> > +# For undefined symbols, the first field (value) is empty.
> > +# The outout looks like this:
> > +# " U _printk"
> > +# It is unneeded to record undefined symbols.
> > +#
> > +# case 2)
> > +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
> > +# "---------------- t"
> > +!length($3) {
> > + next
> > +}
> >
> > -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
> > -while read value type name
> > -do
> > - # Skip the line if the number of fields is less than 3.
> > - #
> > - # case 1)
> > - # For undefined symbols, the first field (value) is empty.
> > - # The outout looks like this:
> > - # " U _printk"
> > - # It is unneeded to record undefined symbols.
> > - #
> > - # case 2)
> > - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
> > - # "---------------- t"
> > - if [[ -z ${name} ]]; then
> > - continue
> > - fi
> > +# save (name, type) in the associative array
> > +{ symbol_types[$3]=$2 }
> >
> > - # save (name, type) in the associative array
> > - symbol_types[${name}]=${type}
> > +# append the exported symbol to the array
> > +($3 ~ /^__ksymtab_/) {
> > + export_symbols[i] = $3
> > + sub(/^__ksymtab_/, "", export_symbols[i])
> > + i++
> > +}
> >
> > - # append the exported symbol to the array
> > - if [[ ${name} == __ksymtab_* ]]; then
> > - export_symbols+=(${name#__ksymtab_})
> > - fi
> > -done
> > +END {
> > + exit_code = 0
> > + for (j = 0; j < i; ++j) {
> > + name = export_symbols[j]
> > + # nm(3) says "If lowercase, the symbol is usually local"
> > + if (symbol_types[name] ~ /[a-z]/) {
> > + printf "%s: error: local symbol %s was exported\n",
> > + file, name | "cat 1>&2"
> > + exit_code = 1
> > + }
> > + }
> >
> > -for name in "${export_symbols[@]}"
> > -do
> > - # nm(3) says "If lowercase, the symbol is usually local"
> > - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
> > - echo "$@: error: local symbol '${name}' was exported" >&2
> > - exit_code=1
> > - fi
> > -done
> > + exit exit_code
> > +}'
> >
> > -exit ${exit_code}
> > +exit $?
> > --
> > 2.37.2
> >
>
>
> --
> Best Regards
> Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-08-31 20:57 ` [PATCH v4] " Owen Rafferty
@ 2022-09-03 16:01 ` Masahiro Yamada
2022-09-06 9:28 ` Masahiro Yamada
0 siblings, 1 reply; 15+ messages in thread
From: Masahiro Yamada @ 2022-09-03 16:01 UTC (permalink / raw)
To: Owen Rafferty; +Cc: Linux Kbuild mailing list
On Thu, Sep 1, 2022 at 6:03 AM Owen Rafferty <owen@owenrafferty.com> wrote:
>
> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
> ---
Please input something in the commit log.
I think the benchmark in v2 is worth mentioning
because "awk is faster than bash" is one benefit
of applying this patch.
> scripts/check-local-export | 96 +++++++++++++++++++-------------------
> 1 file changed, 47 insertions(+), 49 deletions(-)
>
> diff --git a/scripts/check-local-export b/scripts/check-local-export
> index 6ccc2f467416..0c049ff44aca 100755
> --- a/scripts/check-local-export
> +++ b/scripts/check-local-export
> @@ -1,26 +1,14 @@
> -#!/usr/bin/env bash
> +#!/bin/sh
> # SPDX-License-Identifier: GPL-2.0-only
> #
> # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
> +# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
> #
> # Exit with error if a local exported symbol is found.
> # EXPORT_SYMBOL should be used for global symbols.
>
> set -e
>
> -# catch errors from ${NM}
> -set -o pipefail
> -
> -# Run the last element of a pipeline in the current shell.
> -# Without this, the while-loop would be executed in a subshell, and
> -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
> -shopt -s lastpipe
> -
> -declare -A symbol_types
> -declare -a export_symbols
> -
> -exit_code=0
> -
> # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> # '2>/dev/null'. However, it suppresses real error messages as well. Add a
> @@ -29,43 +17,53 @@ exit_code=0
> # TODO:
> # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> # binutils to 2.37, llvm to 13.0.0.
> -# Then, the following line will be really simple:
> -# ${NM} --quiet ${1} |
> +# Then, the following line will be simpler:
> +# { ${NM} --quiet ${1} || kill 0; } |
> +
> +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> +${AWK} -v "file=${1}" '
> +BEGIN {
> + i = 0
> +}
> +
> +# Skip the line if the number of fields is less than 3.
> +#
> +# case 1)
> +# For undefined symbols, the first field (value) is empty.
> +# The outout looks like this:
> +# " U _printk"
> +# It is unneeded to record undefined symbols.
> +#
> +# case 2)
> +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
> +# "---------------- t"
> +!length($3) {
> + next
> +}
>
> -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
> -while read value type name
> -do
> - # Skip the line if the number of fields is less than 3.
> - #
> - # case 1)
> - # For undefined symbols, the first field (value) is empty.
> - # The outout looks like this:
> - # " U _printk"
> - # It is unneeded to record undefined symbols.
> - #
> - # case 2)
> - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
> - # "---------------- t"
> - if [[ -z ${name} ]]; then
> - continue
> - fi
> +# save (name, type) in the associative array
> +{ symbol_types[$3]=$2 }
>
> - # save (name, type) in the associative array
> - symbol_types[${name}]=${type}
> +# append the exported symbol to the array
> +($3 ~ /^__ksymtab_/) {
> + export_symbols[i] = $3
> + sub(/^__ksymtab_/, "", export_symbols[i])
> + i++
> +}
>
> - # append the exported symbol to the array
> - if [[ ${name} == __ksymtab_* ]]; then
> - export_symbols+=(${name#__ksymtab_})
> - fi
> -done
> +END {
> + exit_code = 0
> + for (j = 0; j < i; ++j) {
> + name = export_symbols[j]
> + # nm(3) says "If lowercase, the symbol is usually local"
> + if (symbol_types[name] ~ /[a-z]/) {
> + printf "%s: error: local symbol %s was exported\n",
> + file, name | "cat 1>&2"
> + exit_code = 1
> + }
> + }
>
> -for name in "${export_symbols[@]}"
> -do
> - # nm(3) says "If lowercase, the symbol is usually local"
> - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
> - echo "$@: error: local symbol '${name}' was exported" >&2
> - exit_code=1
> - fi
> -done
> + exit exit_code
> +}'
>
> -exit ${exit_code}
> +exit $?
> --
> 2.37.3
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-09-03 16:01 ` Masahiro Yamada
@ 2022-09-06 9:28 ` Masahiro Yamada
2022-09-27 22:25 ` Randy Dunlap
0 siblings, 1 reply; 15+ messages in thread
From: Masahiro Yamada @ 2022-09-06 9:28 UTC (permalink / raw)
To: Owen Rafferty; +Cc: Linux Kbuild mailing list
On Sun, Sep 4, 2022 at 1:01 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Thu, Sep 1, 2022 at 6:03 AM Owen Rafferty <owen@owenrafferty.com> wrote:
> >
> > Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
> > ---
>
>
> Please input something in the commit log.
>
> I think the benchmark in v2 is worth mentioning
> because "awk is faster than bash" is one benefit
> of applying this patch.
>
>
Applied to linux-kbuild. Thanks.
(V5 was not delivered to ML somehow,
but I found it in my mailbox.)
>
>
>
>
> > scripts/check-local-export | 96 +++++++++++++++++++-------------------
> > 1 file changed, 47 insertions(+), 49 deletions(-)
> >
> > diff --git a/scripts/check-local-export b/scripts/check-local-export
> > index 6ccc2f467416..0c049ff44aca 100755
> > --- a/scripts/check-local-export
> > +++ b/scripts/check-local-export
> > @@ -1,26 +1,14 @@
> > -#!/usr/bin/env bash
> > +#!/bin/sh
> > # SPDX-License-Identifier: GPL-2.0-only
> > #
> > # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
> > +# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
> > #
> > # Exit with error if a local exported symbol is found.
> > # EXPORT_SYMBOL should be used for global symbols.
> >
> > set -e
> >
> > -# catch errors from ${NM}
> > -set -o pipefail
> > -
> > -# Run the last element of a pipeline in the current shell.
> > -# Without this, the while-loop would be executed in a subshell, and
> > -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
> > -shopt -s lastpipe
> > -
> > -declare -A symbol_types
> > -declare -a export_symbols
> > -
> > -exit_code=0
> > -
> > # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> > # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> > # '2>/dev/null'. However, it suppresses real error messages as well. Add a
> > @@ -29,43 +17,53 @@ exit_code=0
> > # TODO:
> > # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
> > # binutils to 2.37, llvm to 13.0.0.
> > -# Then, the following line will be really simple:
> > -# ${NM} --quiet ${1} |
> > +# Then, the following line will be simpler:
> > +# { ${NM} --quiet ${1} || kill 0; } |
> > +
> > +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> > +${AWK} -v "file=${1}" '
> > +BEGIN {
> > + i = 0
> > +}
> > +
> > +# Skip the line if the number of fields is less than 3.
> > +#
> > +# case 1)
> > +# For undefined symbols, the first field (value) is empty.
> > +# The outout looks like this:
> > +# " U _printk"
> > +# It is unneeded to record undefined symbols.
> > +#
> > +# case 2)
> > +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
> > +# "---------------- t"
> > +!length($3) {
> > + next
> > +}
> >
> > -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
> > -while read value type name
> > -do
> > - # Skip the line if the number of fields is less than 3.
> > - #
> > - # case 1)
> > - # For undefined symbols, the first field (value) is empty.
> > - # The outout looks like this:
> > - # " U _printk"
> > - # It is unneeded to record undefined symbols.
> > - #
> > - # case 2)
> > - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
> > - # "---------------- t"
> > - if [[ -z ${name} ]]; then
> > - continue
> > - fi
> > +# save (name, type) in the associative array
> > +{ symbol_types[$3]=$2 }
> >
> > - # save (name, type) in the associative array
> > - symbol_types[${name}]=${type}
> > +# append the exported symbol to the array
> > +($3 ~ /^__ksymtab_/) {
> > + export_symbols[i] = $3
> > + sub(/^__ksymtab_/, "", export_symbols[i])
> > + i++
> > +}
> >
> > - # append the exported symbol to the array
> > - if [[ ${name} == __ksymtab_* ]]; then
> > - export_symbols+=(${name#__ksymtab_})
> > - fi
> > -done
> > +END {
> > + exit_code = 0
> > + for (j = 0; j < i; ++j) {
> > + name = export_symbols[j]
> > + # nm(3) says "If lowercase, the symbol is usually local"
> > + if (symbol_types[name] ~ /[a-z]/) {
> > + printf "%s: error: local symbol %s was exported\n",
> > + file, name | "cat 1>&2"
> > + exit_code = 1
> > + }
> > + }
> >
> > -for name in "${export_symbols[@]}"
> > -do
> > - # nm(3) says "If lowercase, the symbol is usually local"
> > - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
> > - echo "$@: error: local symbol '${name}' was exported" >&2
> > - exit_code=1
> > - fi
> > -done
> > + exit exit_code
> > +}'
> >
> > -exit ${exit_code}
> > +exit $?
> > --
> > 2.37.3
> >
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-09-06 9:28 ` Masahiro Yamada
@ 2022-09-27 22:25 ` Randy Dunlap
2022-09-28 5:38 ` Masahiro Yamada
0 siblings, 1 reply; 15+ messages in thread
From: Randy Dunlap @ 2022-09-27 22:25 UTC (permalink / raw)
To: Masahiro Yamada, Owen Rafferty
Cc: Linux Kbuild mailing list, Nick Desaulniers
Hi,
On 9/6/22 02:28, Masahiro Yamada wrote:
> On Sun, Sep 4, 2022 at 1:01 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>
>> On Thu, Sep 1, 2022 at 6:03 AM Owen Rafferty <owen@owenrafferty.com> wrote:
>>>
>>> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
>>> ---
>>
>>
>> Please input something in the commit log.
>>
>> I think the benchmark in v2 is worth mentioning
>> because "awk is faster than bash" is one benefit
>> of applying this patch.
>>
>>
>
>
>
> Applied to linux-kbuild. Thanks.
>
>
> (V5 was not delivered to ML somehow,
> but I found it in my mailbox.)
Yeah, I haven't seen that one either.
For whatever is in linux-next-20220927, I am seeing something
unpleasant. I'm not positive that it's due to this patch, so I'm
still checking/testing (but I'm about to leave home for awhile so
I wanted to go ahead and let people know about this).
I do N number of randconfig builds in a script (say 10).
What I am seeing is that when an 'nm' error happens, the
script is Terminated and not continued. E.g., if the error
is on randconfig build #4, builds 5-10 are never started.
The controlling script dies.
>>> scripts/check-local-export | 96 +++++++++++++++++++-------------------
>>> 1 file changed, 47 insertions(+), 49 deletions(-)
>>>
>>> diff --git a/scripts/check-local-export b/scripts/check-local-export
>>> index 6ccc2f467416..0c049ff44aca 100755
>>> --- a/scripts/check-local-export
>>> +++ b/scripts/check-local-export
>>> @@ -1,26 +1,14 @@
>>> -#!/usr/bin/env bash
>>> +#!/bin/sh
>>> # SPDX-License-Identifier: GPL-2.0-only
>>> #
>>> # Copyright (C) 2022 Masahiro Yamada <masahiroy@kernel.org>
>>> +# Copyright (C) 2022 Owen Rafferty <owen@owenrafferty.com>
>>> #
>>> # Exit with error if a local exported symbol is found.
>>> # EXPORT_SYMBOL should be used for global symbols.
>>>
>>> set -e
>>>
>>> -# catch errors from ${NM}
>>> -set -o pipefail
>>> -
>>> -# Run the last element of a pipeline in the current shell.
>>> -# Without this, the while-loop would be executed in a subshell, and
>>> -# the changes made to 'symbol_types' and 'export_symbols' would be lost.
>>> -shopt -s lastpipe
>>> -
>>> -declare -A symbol_types
>>> -declare -a export_symbols
>>> -
>>> -exit_code=0
>>> -
>>> # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
>>> # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
>>> # '2>/dev/null'. However, it suppresses real error messages as well. Add a
>>> @@ -29,43 +17,53 @@ exit_code=0
>>> # TODO:
>>> # Use --quiet instead of 2>/dev/null when we upgrade the minimum version of
>>> # binutils to 2.37, llvm to 13.0.0.
>>> -# Then, the following line will be really simple:
>>> -# ${NM} --quiet ${1} |
>>> +# Then, the following line will be simpler:
>>> +# { ${NM} --quiet ${1} || kill 0; } |
>>> +
>>> +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
>>> +${AWK} -v "file=${1}" '
>>> +BEGIN {
>>> + i = 0
>>> +}
>>> +
>>> +# Skip the line if the number of fields is less than 3.
>>> +#
>>> +# case 1)
>>> +# For undefined symbols, the first field (value) is empty.
>>> +# The outout looks like this:
>>> +# " U _printk"
>>> +# It is unneeded to record undefined symbols.
>>> +#
>>> +# case 2)
>>> +# For Clang LTO, llvm-nm outputs a line with type t but empty name:
>>> +# "---------------- t"
>>> +!length($3) {
>>> + next
>>> +}
>>>
>>> -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } } |
>>> -while read value type name
>>> -do
>>> - # Skip the line if the number of fields is less than 3.
>>> - #
>>> - # case 1)
>>> - # For undefined symbols, the first field (value) is empty.
>>> - # The outout looks like this:
>>> - # " U _printk"
>>> - # It is unneeded to record undefined symbols.
>>> - #
>>> - # case 2)
>>> - # For Clang LTO, llvm-nm outputs a line with type 't' but empty name:
>>> - # "---------------- t"
>>> - if [[ -z ${name} ]]; then
>>> - continue
>>> - fi
>>> +# save (name, type) in the associative array
>>> +{ symbol_types[$3]=$2 }
>>>
>>> - # save (name, type) in the associative array
>>> - symbol_types[${name}]=${type}
>>> +# append the exported symbol to the array
>>> +($3 ~ /^__ksymtab_/) {
>>> + export_symbols[i] = $3
>>> + sub(/^__ksymtab_/, "", export_symbols[i])
>>> + i++
>>> +}
>>>
>>> - # append the exported symbol to the array
>>> - if [[ ${name} == __ksymtab_* ]]; then
>>> - export_symbols+=(${name#__ksymtab_})
>>> - fi
>>> -done
>>> +END {
>>> + exit_code = 0
>>> + for (j = 0; j < i; ++j) {
>>> + name = export_symbols[j]
>>> + # nm(3) says "If lowercase, the symbol is usually local"
>>> + if (symbol_types[name] ~ /[a-z]/) {
>>> + printf "%s: error: local symbol %s was exported\n",
>>> + file, name | "cat 1>&2"
>>> + exit_code = 1
>>> + }
>>> + }
>>>
>>> -for name in "${export_symbols[@]}"
>>> -do
>>> - # nm(3) says "If lowercase, the symbol is usually local"
>>> - if [[ ${symbol_types[$name]} =~ [a-z] ]]; then
>>> - echo "$@: error: local symbol '${name}' was exported" >&2
>>> - exit_code=1
>>> - fi
>>> -done
>>> + exit exit_code
>>> +}'
>>>
>>> -exit ${exit_code}
>>> +exit $?
>>> --
>>> 2.37.3
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-09-27 22:25 ` Randy Dunlap
@ 2022-09-28 5:38 ` Masahiro Yamada
2022-09-28 21:23 ` Masahiro Yamada
0 siblings, 1 reply; 15+ messages in thread
From: Masahiro Yamada @ 2022-09-28 5:38 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Owen Rafferty, Linux Kbuild mailing list, Nick Desaulniers
On Wed, Sep 28, 2022 at 7:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> On 9/6/22 02:28, Masahiro Yamada wrote:
> > On Sun, Sep 4, 2022 at 1:01 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >>
> >> On Thu, Sep 1, 2022 at 6:03 AM Owen Rafferty <owen@owenrafferty.com> wrote:
> >>>
> >>> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
> >>> ---
> >>
> >>
> >> Please input something in the commit log.
> >>
> >> I think the benchmark in v2 is worth mentioning
> >> because "awk is faster than bash" is one benefit
> >> of applying this patch.
> >>
> >>
> >
> >
> >
> > Applied to linux-kbuild. Thanks.
> >
> >
> > (V5 was not delivered to ML somehow,
> > but I found it in my mailbox.)
>
> Yeah, I haven't seen that one either.
>
> For whatever is in linux-next-20220927, I am seeing something
> unpleasant. I'm not positive that it's due to this patch, so I'm
> still checking/testing (but I'm about to leave home for awhile so
> I wanted to go ahead and let people know about this).
>
> I do N number of randconfig builds in a script (say 10).
> What I am seeing is that when an 'nm' error happens, the
> script is Terminated and not continued. E.g., if the error
> is on randconfig build #4, builds 5-10 are never started.
> The controlling script dies.
>
Hmm, I have not yet observed such an error.
If it happens depending on a particular configuration,
please share the .config file.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-09-28 5:38 ` Masahiro Yamada
@ 2022-09-28 21:23 ` Masahiro Yamada
2022-09-28 23:26 ` Randy Dunlap
0 siblings, 1 reply; 15+ messages in thread
From: Masahiro Yamada @ 2022-09-28 21:23 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Owen Rafferty, Linux Kbuild mailing list, Nick Desaulniers
On Wed, Sep 28, 2022 at 2:38 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Wed, Sep 28, 2022 at 7:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Hi,
> >
> > On 9/6/22 02:28, Masahiro Yamada wrote:
> > > On Sun, Sep 4, 2022 at 1:01 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >>
> > >> On Thu, Sep 1, 2022 at 6:03 AM Owen Rafferty <owen@owenrafferty.com> wrote:
> > >>>
> > >>> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
> > >>> ---
> > >>
> > >>
> > >> Please input something in the commit log.
> > >>
> > >> I think the benchmark in v2 is worth mentioning
> > >> because "awk is faster than bash" is one benefit
> > >> of applying this patch.
> > >>
> > >>
> > >
> > >
> > >
> > > Applied to linux-kbuild. Thanks.
> > >
> > >
> > > (V5 was not delivered to ML somehow,
> > > but I found it in my mailbox.)
> >
> > Yeah, I haven't seen that one either.
> >
> > For whatever is in linux-next-20220927, I am seeing something
> > unpleasant. I'm not positive that it's due to this patch, so I'm
> > still checking/testing (but I'm about to leave home for awhile so
> > I wanted to go ahead and let people know about this).
> >
> > I do N number of randconfig builds in a script (say 10).
> > What I am seeing is that when an 'nm' error happens, the
> > script is Terminated and not continued. E.g., if the error
> > is on randconfig build #4, builds 5-10 are never started.
> > The controlling script dies.
> >
>
>
> Hmm, I have not yet observed such an error.
>
> If it happens depending on a particular configuration,
> please share the .config file.
>
>
Owen provided the following fix-up.
I see his mail in my mailbox, but not in ML.
(Does the ML reject mails from non-subscribers?)
diff --git a/scripts/check-local-export b/scripts/check-local-export
index 0c049ff44aca..f90b5a9c67b3 100755
--- a/scripts/check-local-export
+++ b/scripts/check-local-export
@@ -8,6 +8,7 @@
# EXPORT_SYMBOL should be used for global symbols.
set -e
+pid=$$
# If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
# 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
@@ -20,7 +21,7 @@ set -e
# Then, the following line will be simpler:
# { ${NM} --quiet ${1} || kill 0; } |
-{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
+{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill $pid; } } |
${AWK} -v "file=${1}" '
BEGIN {
I squashed the diff to the original patch.
Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH v4] kbuild: rewrite check-local-export in sh/awk
2022-09-28 21:23 ` Masahiro Yamada
@ 2022-09-28 23:26 ` Randy Dunlap
0 siblings, 0 replies; 15+ messages in thread
From: Randy Dunlap @ 2022-09-28 23:26 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Owen Rafferty, Linux Kbuild mailing list, Nick Desaulniers
On 9/28/22 14:23, Masahiro Yamada wrote:
> On Wed, Sep 28, 2022 at 2:38 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>
>> On Wed, Sep 28, 2022 at 7:26 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> Hi,
>>>
>>> On 9/6/22 02:28, Masahiro Yamada wrote:
>>>> On Sun, Sep 4, 2022 at 1:01 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>>>>
>>>>> On Thu, Sep 1, 2022 at 6:03 AM Owen Rafferty <owen@owenrafferty.com> wrote:
>>>>>>
>>>>>> Signed-off-by: Owen Rafferty <owen@owenrafferty.com>
>>>>>> ---
>>>>>
>>>>>
>>>>> Please input something in the commit log.
>>>>>
>>>>> I think the benchmark in v2 is worth mentioning
>>>>> because "awk is faster than bash" is one benefit
>>>>> of applying this patch.
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> Applied to linux-kbuild. Thanks.
>>>>
>>>>
>>>> (V5 was not delivered to ML somehow,
>>>> but I found it in my mailbox.)
>>>
>>> Yeah, I haven't seen that one either.
>>>
>>> For whatever is in linux-next-20220927, I am seeing something
>>> unpleasant. I'm not positive that it's due to this patch, so I'm
>>> still checking/testing (but I'm about to leave home for awhile so
>>> I wanted to go ahead and let people know about this).
>>>
>>> I do N number of randconfig builds in a script (say 10).
>>> What I am seeing is that when an 'nm' error happens, the
>>> script is Terminated and not continued. E.g., if the error
>>> is on randconfig build #4, builds 5-10 are never started.
>>> The controlling script dies.
>>>
>>
>>
>> Hmm, I have not yet observed such an error.
>>
>> If it happens depending on a particular configuration,
>> please share the .config file.
>>
>>
>
>
> Owen provided the following fix-up.
> I see his mail in my mailbox, but not in ML.
> (Does the ML reject mails from non-subscribers?)
It shouldn't. AFAIK it only rejects emails that are too large
(e.g., 100 KB) or HTML email.
> diff --git a/scripts/check-local-export b/scripts/check-local-export
> index 0c049ff44aca..f90b5a9c67b3 100755
> --- a/scripts/check-local-export
> +++ b/scripts/check-local-export
> @@ -8,6 +8,7 @@
> # EXPORT_SYMBOL should be used for global symbols.
>
> set -e
> +pid=$$
>
> # If there is no symbol in the object, ${NM} (both GNU nm and llvm-nm) shows
> # 'no symbols' diagnostic (but exits with 0). It is harmless and hidden by
> @@ -20,7 +21,7 @@ set -e
> # Then, the following line will be simpler:
> # { ${NM} --quiet ${1} || kill 0; } |
>
> -{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill 0; } } |
> +{ ${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; kill $pid; } } |
> ${AWK} -v "file=${1}" '
> BEGIN {
>
>
>
>
> I squashed the diff to the original patch.
> Thanks.
That helps quite a bit. Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-09-28 23:26 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 14:18 [PATCH v2] kbuild: rewrite check-local-export in sh/awk Owen Rafferty
2022-08-14 0:23 ` Masahiro Yamada
2022-08-15 0:25 ` Owen Rafferty
2022-08-27 5:40 ` Masahiro Yamada
2022-08-27 14:01 ` Masahiro Yamada
2022-08-27 16:52 ` [PATCH v3] " Owen Rafferty
2022-08-31 6:44 ` Masahiro Yamada
2022-08-31 20:57 ` [PATCH v4] " Owen Rafferty
2022-09-03 16:01 ` Masahiro Yamada
2022-09-06 9:28 ` Masahiro Yamada
2022-09-27 22:25 ` Randy Dunlap
2022-09-28 5:38 ` Masahiro Yamada
2022-09-28 21:23 ` Masahiro Yamada
2022-09-28 23:26 ` Randy Dunlap
2022-08-31 21:03 ` [PATCH v3] " Owen Rafferty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).