From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root
Date: Sun, 4 Oct 2020 20:55:29 +0530 [thread overview]
Message-ID: <0537f532-1499-f644-2c91-ad91da7901df@gmail.com> (raw)
In-Reply-To: <e8b218d4-e64a-ac0a-ea53-567d07a58f42@gmail.com>
On 20-09-2020 01:47, Anant Thazhemadam wrote:
> On 19-09-2020 17:03, Anant Thazhemadam wrote:
>> On 19-09-2020 22:25, Al Viro wrote:
>>> On Sat, Sep 19, 2020 at 05:17:27PM +0100, Al Viro wrote:
>>>
>>>> Lovely... That would get an empty path and non-directory for a starting
>>>> point, but it should end up with LAST_ROOT in nd->last_type. Which should
>>>> not be able to reach the readers of those fields... Which kernel had
>>>> that been on?
>>> Yecchhh... I see what's going on; I suspect that this ought to be enough.
>>> Folks, could somebody test it on the original reproducer setup?
>> Sure. I can do that.
> Looks like this patch actually fixes this bug.
> I made syzbot test the patch, and no issues were triggered!
>
> Note: syzbot tested the patch with the KMSAN kernel, which
> was recently rebased on v5.9-rc4.
>
> Thanks,
> Anant
Ping.
Has the patch that was tested been applied to any tree yet?
If yes, could someone please let me know the commit details, so we can close
the issue? (Unfortunately, I was unable to find it. :( )
Thanks,
Anant
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-04 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 5:26 [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root Anant Thazhemadam
2020-09-16 5:41 ` Eric Biggers
2020-09-17 0:22 ` Al Viro
2020-09-19 14:44 ` Greg KH
2020-09-19 16:17 ` Al Viro
2020-09-19 16:55 ` Al Viro
2020-09-19 11:33 ` Anant Thazhemadam
2020-09-19 20:17 ` Anant Thazhemadam
2020-10-04 15:25 ` Anant Thazhemadam [this message]
2020-09-16 6:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0537f532-1499-f644-2c91-ad91da7901df@gmail.com \
--to=anant.thazhemadam@gmail.com \
--cc=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).