From: Siddh Raman Pant via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: syzbot+c70d87ac1d001f29a058
<syzbot+c70d87ac1d001f29a058@syzkaller.appspotmail.com>,
linux-kernel-mentees
<linux-kernel-mentees@lists.linuxfoundation.org>,
linux-security-modules <linux-security-module@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Subject: Re: [PATCH] kernel/watch_queue: Make pipe NULL while clearing watch_queue
Date: Sat, 23 Jul 2022 19:59:23 +0530 [thread overview]
Message-ID: <1822b768504.1d4e377e236061.5518350412857967240@siddh.me> (raw)
In-Reply-To: <Ytv/4Tljvlt0PJ2r@kroah.com>
On Sat, 23 Jul 2022 19:34:17 +0530 Greg KH <gregkh@linuxfoundation.org> wrote:
> Also you now have a spinlock held when calling rcu_read_unlock(), are
> you sure that's ok?
>
>
We logically should not do write operations in a read critical section, so the
nulling of `wqueue->pipe->watch_queue` should happen after rcu_read_unlock().
Also, since we already have a spinlock, we can use it to ensure the nulling.
So I think it is okay.
Though, it is my first time encountering a spinlock and an rcu lock together,
so if I am wrong, please do correct me.
Thanks,
Siddh
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-07-23 14:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 13:54 [PATCH] kernel/watch_queue: Make pipe NULL while clearing watch_queue Siddh Raman Pant via Linux-kernel-mentees
2022-07-23 14:03 ` Greg KH
2022-07-23 14:29 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-24 3:45 ` Khalid Masum
2022-07-24 4:02 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-23 14:04 ` Greg KH
2022-07-23 14:29 ` Siddh Raman Pant via Linux-kernel-mentees [this message]
2022-07-27 14:46 ` David Howells
2022-07-27 16:20 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-31 18:11 ` Dipanjan Das
2022-07-31 18:46 ` Siddh Raman Pant via Linux-kernel-mentees
2022-08-01 8:47 ` Greg KH
2022-08-01 8:53 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-27 14:15 ` David Howells
2022-07-27 14:23 ` Siddh Raman Pant via Linux-kernel-mentees
[not found] <20220801121513.28E4B5204D1@webmail.sinamail.sina.com.cn>
2022-08-01 12:52 ` Siddh Raman Pant via Linux-kernel-mentees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1822b768504.1d4e377e236061.5518350412857967240@siddh.me \
--to=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=code@siddh.me \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=syzbot+c70d87ac1d001f29a058@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).