From: Jonathan Corbet <corbet@lwn.net>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc: markus.heiser@darmarit.de, linux-doc@vger.kernel.org,
miklos@szeredi.hu, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v4] Documentation: filesystems: convert fuse to RST
Date: Fri, 10 Jan 2020 11:09:23 -0700 [thread overview]
Message-ID: <20200110110923.31fc56e5@lwn.net> (raw)
In-Reply-To: <20191231185110.809467-1-dwlsalmeida@gmail.com>
On Tue, 31 Dec 2019 15:51:10 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
> Converts fuse.txt to reStructuredText format, improving the presentation
> without changing much of the underlying content.
>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
So I note that the last non-typo-fix change to this document happened in
2006, which leads me to suspect that it might be just a wee bit out of
date. Miklos, what's the story here? Should we put a warning at the top?
Otherwise I really only have one other comment on the conversion...
> .../filesystems/{fuse.txt => fuse.rst} | 174 ++++++++----------
> Documentation/filesystems/index.rst | 1 +
> MAINTAINERS | 2 +-
> 3 files changed, 80 insertions(+), 97 deletions(-)
> rename Documentation/filesystems/{fuse.txt => fuse.rst} (79%)
>
> diff --git a/Documentation/filesystems/fuse.txt b/Documentation/filesystems/fuse.rst
> similarity index 79%
> rename from Documentation/filesystems/fuse.txt
> rename to Documentation/filesystems/fuse.rst
> index 13af4a49e7db..aa7d6f506b8d 100644
> --- a/Documentation/filesystems/fuse.txt
> +++ b/Documentation/filesystems/fuse.rst
> @@ -1,41 +1,39 @@
> -Definitions
> -~~~~~~~~~~~
> +==============
> +FUSE
> +==============
>
> -Userspace filesystem:
> +Definitions
> +===========
>
> +``Userspace filesystem:``
> A filesystem in which data and metadata are provided by an ordinary
> userspace process. The filesystem can be accessed normally through
> the kernel interface.
I think that ``literal text`` should really only be used for literal text -
something that the user types, function names, etc. Here you're defining a
term, which is different. You could use **emphasis** as you have in other
places, but I also honestly think it doesn't need special markup at all.
Thanks,
jon
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-10 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 18:51 [Linux-kernel-mentees] [PATCH v4] Documentation: filesystems: convert fuse to RST Daniel W. S. Almeida
2020-01-10 18:09 ` Jonathan Corbet [this message]
2020-01-13 8:51 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110110923.31fc56e5@lwn.net \
--to=corbet@lwn.net \
--cc=dwlsalmeida@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).