From: David Miller <davem@davemloft.net>
To: vaibhavgupta40@gmail.com
Cc: steve.glendinning@shawell.net, linux-kernel@vger.kernel.org,
helgaas@kernel.org, netdev@vger.kernel.org, bhelgaas@google.com,
kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2 0/2] smsc: use generic power management
Date: Tue, 07 Jul 2020 15:22:17 -0700 (PDT) [thread overview]
Message-ID: <20200707.152217.580419867258219789.davem@davemloft.net> (raw)
In-Reply-To: <20200703030138.25724-1-vaibhavgupta40@gmail.com>
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Date: Fri, 3 Jul 2020 08:31:36 +0530
> Linux Kernel Mentee: Remove Legacy Power Management.
>
> The purpose of this patch series is to remove legacy power management callbacks
> from smsc ethernet drivers.
>
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the power management
> themselves, which is not recommended.
>
> The conversion requires the removal of the those function calls and change the
> callback definition accordingly and make use of dev_pm_ops structure.
>
> All patches are compile-tested only.
>
> V2: Kbuild in V1, warning: variable 'err' is used uninitialized whenever 'if'
> conditio is false in funcution .resume() .
Series applied to net-next, thanks.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-07-07 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 3:01 [Linux-kernel-mentees] [PATCH v2 0/2] smsc: use generic power management Vaibhav Gupta
2020-07-03 3:01 ` [Linux-kernel-mentees] [PATCH v2 1/2] epic100: " Vaibhav Gupta
2020-07-03 3:01 ` [Linux-kernel-mentees] [PATCH v2 2/2] smsc9420: " Vaibhav Gupta
2020-07-07 22:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707.152217.580419867258219789.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).