From: Vaibhav Gupta <vaibhav.varodek@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-ide@vger.kernel.org,
Vaibhav Gupta <vaibhavgupta40@gmail.com>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH v3 0/3] drivers: ide: use generic power management
Date: Tue, 14 Jul 2020 13:22:47 +0530 [thread overview]
Message-ID: <20200714075247.GA4859@gmail.com> (raw)
In-Reply-To: <3b26bfff-7a42-7bbe-2050-51fe1ce96d4e@samsung.com>
On Tue, Jul 14, 2020 at 09:32:56AM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On 7/13/20 7:36 PM, Vaibhav Gupta wrote:
> > Linux Kernel Mentee: Remove Legacy Power Management.
> >
> > The purpose of this patch series is to remove legacy power management callbacks
> > from ide drivers.
> >
> > The suspend() and resume() callbacks operations are still invoking
> > pci_save/restore_state(), pci_set_power_state(), pci_enable/disable_state(),
> > etc. and handling the power management themselves, which is not recommended.
> >
> > The conversion requires the removal of the those function calls and change the
> > callback definition accordingly and make use of dev_pm_ops structure.
>
> IDE subsystem (drivers/ide/) is deprecated and has been superseded by libata
> subsystem (drivers/ata/).
>
> libata drivers have the same issue so please concentrate on fixing them
> first. Later (if desirable) changes can be back-ported to drivers/ide/.
>
Hello, (drivers/ide) and (drivers/ata) are the two major families, I am working
on, for generic PM upgradation. I was bit unaware about priority, and also in
the last, both ide and ata drivers have to be upgraded.
> > All patches are compile-tested only.
>
> This patchset needs (at least) some basic testing. It should be easier with
> libata subsystem as it also support SATA controllers and devices.
To upgrade PM in (drivers/ide) I have made .suspend() and .resume() static. Then
bind them in "struct dev_pm_ops" variable (ide_pci_pm_ops) and expose it using
EXPORT_SYMBOL_GPL(). This has affected 30 drivers. I was hoping if ide changes
can be tested/verified, specially [PATCH 1/3]. As then, I will be sure about
similar change in ata, as it also requires similar alteration.
Thanks
Vaibhav Gupta
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> > v3:
> > - Modpost error for undefined reference by Kbuild in v1.
> > - Another approach to disable PM in drivers/ide/triflex.c suggested by
> > Bjorn Helgaas in v2.
> >
> > Test tools:
> > - Compiler: gcc (GCC) 10.1.0
> > - allmodconfig build: make -j$(nproc) W=1 all
> >
> > Vaibhav Gupta (3):
> > ide: use generic power management
> > ide: sc1200: use generic power management
> > ide: delkin_cb: use generic power management
> >
> > drivers/ide/aec62xx.c | 3 +--
> > drivers/ide/alim15x3.c | 3 +--
> > drivers/ide/amd74xx.c | 3 +--
> > drivers/ide/atiixp.c | 3 +--
> > drivers/ide/cmd64x.c | 3 +--
> > drivers/ide/cs5520.c | 3 +--
> > drivers/ide/cs5530.c | 3 +--
> > drivers/ide/cs5535.c | 3 +--
> > drivers/ide/cs5536.c | 3 +--
> > drivers/ide/cy82c693.c | 3 +--
> > drivers/ide/delkin_cb.c | 32 +++++---------------------
> > drivers/ide/hpt366.c | 3 +--
> > drivers/ide/ide-pci-generic.c | 3 +--
> > drivers/ide/it8172.c | 3 +--
> > drivers/ide/it8213.c | 3 +--
> > drivers/ide/it821x.c | 3 +--
> > drivers/ide/jmicron.c | 3 +--
> > drivers/ide/ns87415.c | 3 +--
> > drivers/ide/opti621.c | 3 +--
> > drivers/ide/pdc202xx_new.c | 3 +--
> > drivers/ide/pdc202xx_old.c | 3 +--
> > drivers/ide/piix.c | 3 +--
> > drivers/ide/sc1200.c | 43 ++++++++++++-----------------------
> > drivers/ide/serverworks.c | 3 +--
> > drivers/ide/setup-pci.c | 29 +++++------------------
> > drivers/ide/siimage.c | 3 +--
> > drivers/ide/sis5513.c | 3 +--
> > drivers/ide/sl82c105.c | 3 +--
> > drivers/ide/slc90e66.c | 3 +--
> > drivers/ide/triflex.c | 24 +++++++------------
> > drivers/ide/via82cxxx.c | 3 +--
> > include/linux/ide.h | 8 +------
> > 32 files changed, 62 insertions(+), 155 deletions(-)
> >
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-14 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 17:36 [Linux-kernel-mentees] [PATCH v3 0/3] drivers: ide: use generic power management Vaibhav Gupta
2020-07-13 17:36 ` [Linux-kernel-mentees] [PATCH v3 1/3] " Vaibhav Gupta
2020-07-13 17:36 ` [Linux-kernel-mentees] [PATCH v3 2/3] ide: sc1200: " Vaibhav Gupta
2020-07-13 17:36 ` [Linux-kernel-mentees] [PATCH v3 3/3] ide: delkin_cb: " Vaibhav Gupta
[not found] ` <CGME20200714073256eucas1p13ebe9585c29b766e48506400ba91a8ed@eucas1p1.samsung.com>
2020-07-14 7:32 ` [Linux-kernel-mentees] [PATCH v3 0/3] drivers: ide: " Bartlomiej Zolnierkiewicz
2020-07-14 7:52 ` Vaibhav Gupta [this message]
2020-07-14 8:19 ` Bartlomiej Zolnierkiewicz
2020-07-14 8:24 ` Vaibhav Gupta
2020-08-04 1:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714075247.GA4859@gmail.com \
--to=vaibhav.varodek@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).