From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] ata: use generic power management
Date: Mon, 27 Jul 2020 23:41:44 +0530 [thread overview]
Message-ID: <20200727181144.GA543@gmail.com> (raw)
In-Reply-To: <99b7cc57-1b4f-6c0b-00c6-08e22021c373@kernel.dk>
On Mon, Jul 27, 2020 at 11:59:05AM -0600, Jens Axboe wrote:
> On 7/27/20 11:51 AM, Vaibhav Gupta wrote:
> > On Mon, Jul 27, 2020 at 11:42:51AM -0600, Jens Axboe wrote:
> >> On 7/27/20 11:40 AM, Vaibhav Gupta wrote:
> >>> The patch is compile-tested only.
> >>
> >> Please test and verify actual functionality, if you're serious about
> >> potentially getting this into the kernel.
> >>
> > Hello Jens,
> >
> > Sadly I don't have the hardware. This upgrade is part of my Linux Kernel
> > Mentorship Program project. Like other PCI drivers which I have updated, I could
> > do compile-testing only. Though this patch covers 54 drivers but the actual
> > change is done only in drivers/ata/libata-core. Since rest of the drivers
> > make use of the same ata_pci_device_suspend/resume(), it was a chain reaction. I
> > only had to change variable binding in "struct pci_driver" variable of dependent
> > drivers.
>
> That's understandable, but you should find at least some hardware (maybe remotely
> accessible) to test this on. I'm not going to apply this without some confidence
> that it actually works, and compile only testing is a far cry from that. Lots of
> code compiles, but fails miserably at runtime.
>
> While it's touching 54 drivers, at least basic coverage of the most popular
> choices will give everybody some confidence that it works in general.
>
Yes, I agree. Actually with previous drivers, I was able to get help from
maintainers and/or supporters for the hardware testing. Is that possible for
this patch?
Thanks
Vaibhav Gupta
> --
> Jens Axboe
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-27 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 17:39 [Linux-kernel-mentees] [PATCH v2] ata: use generic power management Vaibhav Gupta
2020-07-27 17:40 ` Vaibhav Gupta
2020-07-27 17:42 ` Jens Axboe
2020-07-27 17:51 ` Vaibhav Gupta
2020-07-27 17:59 ` Jens Axboe
2020-07-27 18:11 ` Vaibhav Gupta [this message]
2020-07-27 20:30 ` Jens Axboe
2020-07-28 5:17 ` Vaibhav Gupta
2020-07-28 15:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727181144.GA543@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).