From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
Tomoya MORINAGA <tomoya.rohm@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-i2c@vger.kernel.org,
Vaibhav Gupta <vaibhavgupta40@gmail.com>
Subject: [Linux-kernel-mentees] [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume
Date: Thu, 6 Aug 2020 01:06:15 +0530 [thread overview]
Message-ID: <20200805193616.384313-2-vaibhavgupta40@gmail.com> (raw)
In-Reply-To: <20200805193616.384313-1-vaibhavgupta40@gmail.com>
The driver calls pci_enable_wake(...., false) in pch_i2c_suspend() as well
as pch_i2c_resume(). Either it should enable-wake the device in .suspend()
or should not invoke pci_enable_wake() at all.
Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
.suspend() and .resume().
Reported-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
drivers/i2c/busses/i2c-eg20t.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 73f139690e4e..eb41de22d461 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -879,7 +879,6 @@ static int pch_i2c_suspend(struct pci_dev *pdev, pm_message_t state)
return ret;
}
- pci_enable_wake(pdev, PCI_D3hot, 0);
pci_disable_device(pdev);
pci_set_power_state(pdev, pci_choose_state(pdev, state));
@@ -899,8 +898,6 @@ static int pch_i2c_resume(struct pci_dev *pdev)
return -EIO;
}
- pci_enable_wake(pdev, PCI_D3hot, 0);
-
for (i = 0; i < adap_info->ch_num; i++)
pch_i2c_init(&adap_info->pch_data[i]);
--
2.27.0
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-08-05 19:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 14:00 [Linux-kernel-mentees] [PATCH v1] i2c: eg20t: use generic power management Vaibhav Gupta
2020-08-05 9:16 ` Wolfram Sang
2020-08-05 15:23 ` Bjorn Helgaas
2020-08-05 15:28 ` Bjorn Helgaas
2020-08-05 16:21 ` Vaibhav Gupta
2020-08-05 16:56 ` Bjorn Helgaas
2020-08-05 17:19 ` Vaibhav Gupta
2020-08-05 19:36 ` [Linux-kernel-mentees] [PATCH v2 0/2] i2c: eg20t: Power management upgrade and clean-ups Vaibhav Gupta
2020-08-05 19:36 ` Vaibhav Gupta [this message]
2020-08-10 14:01 ` [Linux-kernel-mentees] [PATCH v2 1/2] i2c: eg20t: Drop PCI wakeup calls from .suspend/.resume Wolfram Sang
2020-08-05 19:36 ` [Linux-kernel-mentees] [PATCH v2 2/2] i2c: eg20t: use generic power management Vaibhav Gupta
2020-08-07 20:23 ` Bjorn Helgaas
2020-08-10 9:18 ` Vaibhav Gupta
2020-08-25 9:53 ` Jean Delvare
2020-08-25 15:16 ` Bjorn Helgaas
2020-08-10 14:01 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805193616.384313-2-vaibhavgupta40@gmail.com \
--to=vaibhavgupta40@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=tomoya.rohm@gmail.com \
--cc=vaibhav.varodek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).