archive mirror
 help / color / mirror / Atom feed
From: Anant Thazhemadam <>
Cc: Anant Thazhemadam <>,,,
	Masahiro Yamada <>,
	Manivannan Sadhasivam <>,,
	Bjorn Andersson <>,,,,
	Jakub Kicinski <>,,
	"David S. Miller" <>
Subject: [Linux-kernel-mentees] [PATCH] net: qrtr: Reintroduce ARCH_QCOM as a dependency for QRTR
Date: Wed,  9 Sep 2020 05:03:28 +0530	[thread overview]
Message-ID: <> (raw)

Removing ARCH_QCOM, as a dependency for QRTR begins to give rise to
issues with respect to maintaining reference count integrity and
suspicious rcu usage.

The bugs resolved by making QRTR dependent on ARCH_QCOM include:

* WARNING: refcount bug in qrtr_node_lookup
* WARNING: refcount bug in qrtr_recvmsg
* WARNING: suspicious RCU usage in ctrl_cmd_new_lookup
* WARNING: suspicious RCU usage in qrtr_ns_worker

Signed-off-by: Anant Thazhemadam <>
As I understand it, QRTR was initially dependent upon ARCH_QCOM, but was 
removed since not all modems using IPC Router protocol required the 
support provided for Qualcomm platforms. 
However, wouldn't ARCH_QCOM be required by the modems that require the 
support provided for Qualcomm platforms?
The configuration ARCH_QCOM isn't exactly the easiest to find, especially, 
for those who don't know what they're looking for (syzbot included, I 
I don't feel like the tradeoff of not depending on ARCH_QCOM over giving 
rise to potential bugs is worth it. 
Is NOT having QRTR depend on ARCH_QCOM so critical that it supersedes the 
priority of not giving rise to potential bugs?

 net/qrtr/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/qrtr/Kconfig b/net/qrtr/Kconfig
index b4020b84760f..8156d0f3656b 100644
--- a/net/qrtr/Kconfig
+++ b/net/qrtr/Kconfig
@@ -4,6 +4,7 @@
 config QRTR
 	tristate "Qualcomm IPC Router support"
+	depends on ARCH_QCOM
 	  Say Y if you intend to use Qualcomm IPC router protocol.  The
 	  protocol is used to communicate with services provided by other

Linux-kernel-mentees mailing list

             reply	other threads:[~2020-09-08 23:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 23:33 Anant Thazhemadam [this message]
2020-09-08 23:40 ` [Linux-kernel-mentees] [PATCH] net: qrtr: Reintroduce ARCH_QCOM as a dependency for QRTR Anant Thazhemadam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).