From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: r.verdejo@samsung.com, linux-kernel@vger.kernel.org,
nicolas@ndufresne.ca,
linux-kernel-mentees@lists.linuxfoundation.org,
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [v10 0/4] media: vidtv: Implement a virtual DVB driver
Date: Sat, 12 Sep 2020 11:15:06 +0200 [thread overview]
Message-ID: <20200912111506.2d2bd512@coco.lan> (raw)
In-Reply-To: <94faa1f5-22b2-1a01-0812-526e8cf17596@xs4all.nl>
Hi Hans/Daniel,
Em Sat, 12 Sep 2020 10:21:59 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> > Building vidtv
> > --------------
> > vidtv is a test driver and thus is **not** enabled by default when
> > compiling the kernel.
> >
> > In order to enable compilation of vidtv:
> >
> > - Enable **DVB_TEST_DRIVERS**, then
> > - Enable **DVB_VIDTV**
> >
> > When compiled as a module, expect the following .ko files:
> >
> > - dvb_vidtv_tuner.ko
> >
> > - dvb_vidtv_demod.ko
> >
> > - dvb_vidtv_bridge.ko
>
> Why the dvb_ prefix? All virtual drivers just start with 'vi'.
>
> And wouldn't it make more sense to call dvb_vidtv_bridge.ko just vidtv.ko?
> Just like the other virtual media drivers?
It is a sort of standard to use dvb_* for pure digital tv
bridge drivers.
Yet, I agree with you that at least an alias is needed.
earlier today, I wrote a patch with such purpose:
https://patchwork.linuxtv.org/project/linux-media/patch/fccf254e33bdd169dde6bdd6f941cf773c82a1c0.1599901499.git.mchehab+huawei@kernel.org/
Still, maybe we should move dvb_vidtv_tuner.ko and dvb_vidtv_demod.ko
to dvb-frontends and rename them. Not 100% sure about that, though.
I would also rename vidtv_bridge.c to just vidtv.c.
Thanks,
Mauro
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-12 9:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 12:58 [Linux-kernel-mentees] [v10 0/4] media: vidtv: Implement a virtual DVB driver Daniel W. S. Almeida
2020-08-21 12:58 ` [Linux-kernel-mentees] [v10 1/4] media: vidtv: implement a tuner driver Daniel W. S. Almeida
2020-08-21 12:58 ` [Linux-kernel-mentees] [v10 2/4] media: vidtv: implement a demodulator driver Daniel W. S. Almeida
2020-08-21 12:58 ` [Linux-kernel-mentees] [v10 3/4] media: vidtv: add a bridge driver Daniel W. S. Almeida
2020-09-15 11:53 ` Geert Uytterhoeven
2020-09-15 13:26 ` Daniel W. S. Almeida
2020-09-15 13:35 ` Geert Uytterhoeven
2020-09-15 18:13 ` Daniel W. S. Almeida
2020-09-16 7:01 ` Mauro Carvalho Chehab
2020-08-21 12:58 ` [Linux-kernel-mentees] [v10 4/4] media: Documentation: vidtv: Add ReST documentation for vidtv Daniel W. S. Almeida
2020-09-11 8:02 ` [Linux-kernel-mentees] [v10 0/4] media: vidtv: Implement a virtual DVB driver Mauro Carvalho Chehab
2020-09-11 12:18 ` Daniel W. S. Almeida
2020-09-11 13:10 ` Mauro Carvalho Chehab
2020-09-11 13:56 ` Mauro Carvalho Chehab
2020-09-12 2:54 ` Daniel W. S. Almeida
2020-09-12 7:38 ` Mauro Carvalho Chehab
2020-09-12 8:21 ` Hans Verkuil
2020-09-12 9:15 ` Mauro Carvalho Chehab [this message]
2020-09-12 14:49 ` Daniel W. S. Almeida
2020-09-12 17:57 ` Mauro Carvalho Chehab
2020-09-14 8:33 ` Hans Verkuil
2020-09-12 8:35 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200912111506.2d2bd512@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=dwlsalmeida@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=r.verdejo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).