From: Matthew Wilcox <willy@infradead.org>
To: Anmol Karn <anmol.karan123@gmail.com>
Cc: Necip Fazil Yildiran <necip@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Eric Biggers <ebiggers@google.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-fsdevel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON_ONCE() when trying to check id
Date: Mon, 14 Sep 2020 20:26:55 +0100 [thread overview]
Message-ID: <20200914192655.GW6583@casper.infradead.org> (raw)
In-Reply-To: <20200914184755.GB213347@Thinkpad>
On Tue, Sep 15, 2020 at 12:17:55AM +0530, Anmol Karn wrote:
> On Mon, Sep 14, 2020 at 12:08:03PM +0100, Matthew Wilcox wrote:
> > On Mon, Sep 14, 2020 at 12:47:24PM +0530, Anmol Karn wrote:
> > > idr_get_next() gives WARN_ON_ONCE() when it gets (id > INT_MAX) true
> > > and this happens when syzbot does fuzzing, and that warning is
> > > expected, but WARN_ON_ONCE() is not required here and, cecking
> > > the condition and returning NULL value would be suffice.
> > >
> > > Reference: commit b9959c7a347 ("filldir[64]: remove WARN_ON_ONCE() for bad directory entries")
> > > Reported-and-tested-by: syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com
> > > Link: https://syzkaller.appspot.com/bug?extid=f7204dcf3df4bb4ce42c
> > > Signed-off-by: Anmol Karn <anmol.karan123@gmail.com>
> >
> > https://lore.kernel.org/netdev/20200605120037.17427-1-willy@infradead.org/
>
> Hello sir,
>
> I have looked into the patch, and it seems the problem is fixed to the root cause
> in this patch, but not yet merged due to some backport issues, so, please ignore
> this patch(sent by me), and please let me know if i can contribute to fixing this
> bug's root cause.
The root cause is that the network maintainers believe I have a far
greater interest in the qrtr code than I actually do, and the maintainer
of the qrtr code is not doing anything.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-14 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:17 [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON_ONCE() when trying to check id Anmol Karn
2020-09-14 11:08 ` Matthew Wilcox
2020-09-14 18:47 ` Anmol Karn
2020-09-14 19:26 ` Matthew Wilcox [this message]
2020-09-15 5:13 ` Anmol Karn
2020-09-15 5:26 ` Eric Biggers
2020-09-15 5:51 ` Anmol Karn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914192655.GW6583@casper.infradead.org \
--to=willy@infradead.org \
--cc=anmol.karan123@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=necip@google.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).