From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: lukas.bulwahn@gmail.com
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
dwaipayaray1@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Linux-kernel-mentees] [PATCH RFC] checkpatch: fix multistatement macro checks
Date: Wed, 30 Sep 2020 02:27:31 +0530 [thread overview]
Message-ID: <20200929205731.207393-1-dwaipayanray1@gmail.com> (raw)
Checkpatch generates incorrect error message for certain
macros.
When checkpatch was run on commit 4649079b9de1
"tracing: Make ftrace packed events have align of 1"), it
generated multiple errors of the form:
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
+#define __field_packed(type, container, item) type item;
This should certainly not be enclosed in a do - while loop.
The problem was with the trailing semicolon. Any statement
with trailing semicolon was marked as a multi-line macro.
This was fixed by having a seperate rule for excluding
single statements terminated by semicolon.
The second problem is due to while (...) {...} macros not being
handled.
For example, on commit fe557319aa06 ("maccess: rename probe_kernel_
{read,write} to copy_{from,to}_kernel_nofault"), checkpatch
generated following error:
ERROR: Macros with multiple statements should be enclosed in a do -
while loop
+#define copy_to_kernel_nofault_loop(dst, src, len, type, err_label) \
while (len >= sizeof(type)) {
....
This was fixed by having a seperate rule to match such while blocks.
Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9e65d21456f1..4fb612200c27 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5342,10 +5342,12 @@ sub process {
$dstat !~ /^\.$Ident\s*=/ && # .foo =
$dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ && # stringification #foo
$dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
+ $dstat !~ /^while\s*$Constant\s*$Constant$/ && # while (...) {...}
$dstat !~ /^for\s*$Constant$/ && # for (...)
$dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar()
$dstat !~ /^do\s*{/ && # do {...
$dstat !~ /^\(\{/ && # ({...
+ $dstat !~ /;$/ && # statement;
$ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/)
{
if ($dstat =~ /^\s*if\b/) {
--
2.27.0
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next reply other threads:[~2020-09-29 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 20:57 Dwaipayan Ray [this message]
2020-09-30 19:10 ` [Linux-kernel-mentees] [PATCH RFC] checkpatch: fix multistatement macro checks Lukas Bulwahn
2020-09-30 19:22 ` Dwaipayan Ray
2020-09-30 19:37 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929205731.207393-1-dwaipayanray1@gmail.com \
--to=dwaipayanray1@gmail.com \
--cc=dwaipayaray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).