From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: mst@redhat.com, jasowang@redhat.com, davem@davemloft.net,
kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com
Cc: Anant Thazhemadam <anant.thazhemadam@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, bpf@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Linux-kernel-mentees] [PATCH 0/2] reorder members of structures in virtio_net for optimization
Date: Wed, 30 Sep 2020 10:47:20 +0530 [thread overview]
Message-ID: <20200930051722.389587-1-anant.thazhemadam@gmail.com> (raw)
The structures virtnet_info and receive_queue have byte holes in
middle, and their members could do with some rearranging
(order-of-declaration wise) in order to overcome this.
Rearranging the members helps in:
* elimination the byte holes in the middle of the structures
* reduce the size of the structure (virtnet_info)
* have more members stored in one cache line (as opposed to
unnecessarily crossing the cacheline boundary and spanning
different cachelines)
The analysis was performed using pahole.
These patches may be applied in any order.
Anant Thazhemadam (2):
net: reorder members of virtnet_info for optimization
net: reorder members of receive_queue in virtio_net for optimization
drivers/net/virtio_net.c | 44 +++++++++++++++++++++-------------------
1 file changed, 23 insertions(+), 21 deletions(-)
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next reply other threads:[~2020-09-30 5:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 5:17 Anant Thazhemadam [this message]
2020-09-30 5:17 ` [Linux-kernel-mentees] [PATCH 1/2] net: reorder members of virtnet_info for optimization Anant Thazhemadam
2020-09-30 5:17 ` [Linux-kernel-mentees] [PATCH 2/2] net: reorder members of receive_queue in virtio_net " Anant Thazhemadam
2020-10-03 2:06 ` [Linux-kernel-mentees] [PATCH 0/2] reorder members of structures " David Miller
2020-10-03 18:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930051722.389587-1-anant.thazhemadam@gmail.com \
--to=anant.thazhemadam@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).