From: David Miller <davem@davemloft.net>
To: anant.thazhemadam@gmail.com
Cc: petkan@nucleusys.com,
syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, kuba@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address
Date: Thu, 01 Oct 2020 19:15:22 -0700 (PDT) [thread overview]
Message-ID: <20201001.191522.1749084221364678705.davem@davemloft.net> (raw)
In-Reply-To: <20201001073221.239618-1-anant.thazhemadam@gmail.com>
From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Date: Thu, 1 Oct 2020 13:02:20 +0530
> When get_registers() fails (which happens when usb_control_msg() fails)
> in set_ethernet_addr(), the uninitialized value of node_id gets copied
> as the address.
>
> Checking for the return values appropriately, and handling the case
> wherein set_ethernet_addr() fails like this, helps in avoiding the
> mac address being incorrectly set in this manner.
>
> Reported-by: syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com
> Tested-by: syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> Acked-by: Petko Manolov <petkan@nucleusys.com>
First, please remove "Linux-kernel-mentees" from the Subject line.
All patch submitters should have their work judged equally, whoever
they are. So this Subject text gives no extra information, and it
simply makes scanning Subject lines in one's mailer more difficult.
Second, when a MAC address fails to probe a random MAC address should
be selected. We have helpers for this. This way an interface still
comes up and is usable, even in the event of a failed MAC address
probe.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-02 2:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 7:32 [Linux-kernel-mentees] [PATCH v2] net: usb: rtl8150: prevent set_ethernet_addr from setting uninit address Anant Thazhemadam
2020-10-02 2:15 ` David Miller [this message]
2020-10-02 11:34 ` Anant Thazhemadam
2020-10-02 11:54 ` Greg KH
2020-10-02 12:05 ` Anant Thazhemadam
2020-10-02 14:29 ` Petko Manolov
2020-10-03 5:51 ` Anant Thazhemadam
2020-10-02 22:38 ` David Miller
2020-10-03 5:54 ` Anant Thazhemadam
2020-10-03 19:38 ` Joe Perches
2020-10-03 20:58 ` Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001.191522.1749084221364678705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anant.thazhemadam@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petkan@nucleusys.com \
--cc=syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).