From: Alan Stern <stern@rowland.harvard.edu>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: linux-usb@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Oliver Neukum <oneukum@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API
Date: Thu, 29 Oct 2020 12:30:14 -0400 [thread overview]
Message-ID: <20201029163014.GC1324094@rowland.harvard.edu> (raw)
In-Reply-To: <d8417f98-0896-25d0-e72d-dcf111011129@gmail.com>
On Thu, Oct 29, 2020 at 08:46:59PM +0530, Anant Thazhemadam wrote:
> I had a v2 prepared and ready but was told to wait for a week before sending it in,
> since usb_control_msg_{send|recv}() that were being used were not present in the
> networking tree at the time, and all the trees would be converged by then.
> So, just to be on the safer side, I waited for two weeks.
> I checked the net tree, and found the APIs there too (defined in usb.h).
>
> However the build seems to fail here,
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/O2BERGN7SYYC6LNOOKNUGPS2IJLDWYT7/
>
> I'm not entirely sure at this point why this is happening, and would appreciate it if
> someone could take the time to tell me if and how this might be an issue with my
> patch.
It's happening because the tree you used for building did not include
the declarations of usb_control_msg_{send|recv}().
It's hard to tell exactly what that tree does contain, because the
github.com links embedded in the web page you mention above don't work.
Alan Stern
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-29 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 6:56 [Linux-kernel-mentees] [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API Anant Thazhemadam
2020-10-10 17:03 ` Jakub Kicinski
2020-10-10 17:48 ` Anant Thazhemadam
2020-10-13 0:14 ` kernel test robot
2020-10-29 13:22 ` [Linux-kernel-mentees] [PATCH v2] " Anant Thazhemadam
2020-10-29 15:16 ` Anant Thazhemadam
2020-10-29 16:30 ` Alan Stern [this message]
2020-10-31 21:11 ` Jakub Kicinski
2020-10-31 21:31 ` Anant Thazhemadam
2020-10-31 21:35 ` [Linux-kernel-mentees] [PATCH v3] " Anant Thazhemadam
2020-11-02 9:40 ` Oliver Neukum
2020-11-02 16:40 ` Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029163014.GC1324094@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=anant.thazhemadam@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).