From: Hillf Danton <hdanton@sina.com>
To: Siddh Raman Pant <code@siddh.me>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
syzbot+c70d87ac1d001f29a058
<syzbot+c70d87ac1d001f29a058@syzkaller.appspotmail.com>,
David Howells <dhowells@redhat.com>,
linux-security-modules <linux-security-module@vger.kernel.org>,
linux-kernel-mentees
<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH v2] kernel/watch_queue: Make pipe NULL while clearing watch_queue
Date: Sun, 24 Jul 2022 15:19:58 +0800 [thread overview]
Message-ID: <20220724071958.2557-1-hdanton@sina.com> (raw)
In-Reply-To: <1822ee2c605.4a717678627753.351372059135065111@siddh.me>
On Sun, 24 Jul 2022 11:56:30 +0530 Siddh Raman Pant wrote:
>
> Before post_one_notification(), in __post_watch_notification(), on line 228
> wqueue->lock is acquired (using lock_wqueue()).
Yes, you are right. I missed 353f7988dd84 ("watchqueue: make sure to serialize
'wqueue->defunct' properly"). Sorry for my noise.
Given defunct serialized, still need to clear wqueue->pipe in the clear
path as proposed?
Hillf
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-07-24 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220724052426.2504-1-hdanton@sina.com>
2022-07-24 6:26 ` [PATCH v2] kernel/watch_queue: Make pipe NULL while clearing watch_queue Siddh Raman Pant via Linux-kernel-mentees
2022-07-24 7:19 ` Hillf Danton [this message]
2022-07-24 7:48 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-27 14:49 ` David Howells
2022-07-24 4:02 Siddh Raman Pant via Linux-kernel-mentees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220724071958.2557-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=code@siddh.me \
--cc=dhowells@redhat.com \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=syzbot+c70d87ac1d001f29a058@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).