From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org,
syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] bluetooth: hci_h5: close serdev device and free hu in h5_close
Date: Thu, 1 Oct 2020 12:45:41 +0530 [thread overview]
Message-ID: <40cdb070-a170-e979-6564-8abb0113570b@gmail.com> (raw)
In-Reply-To: <9D145813-A4B8-46AB-A55F-54C4AF82FD19@holtmann.org>
On 01/10/20 12:38 pm, Marcel Holtmann wrote:
> Hi Anant,
>
>> When h5_close() gets called, the memory allocated for the hu gets
>> freed only if hu->serdev doesn't exist. This leads to a memory leak.
>> So when h5_close() is requested, close the serdev device instance and
>> free the memory allocated to the hu entirely instead.
>>
>> Fixes: https://syzkaller.appspot.com/bug?extid=6ce141c55b2f7aafd1c4
>> Reported-by: syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com
>> Tested-by: syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com
>> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
>> ---
>> drivers/bluetooth/hci_h5.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
> patch has been applied to bluetooth-next tree.
>
> Regards
>
> Marcel
Great! Thanks :)
Thanks,
Anant
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-10-01 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 18:58 [Linux-kernel-mentees] [PATCH] bluetooth: hci_h5: close serdev device and free hu in h5_close Anant Thazhemadam
2020-10-01 7:08 ` Marcel Holtmann
2020-10-01 7:15 ` Anant Thazhemadam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40cdb070-a170-e979-6564-8abb0113570b@gmail.com \
--to=anant.thazhemadam@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).