From: Marcel Holtmann <marcel@holtmann.org>
To: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
syzkaller-bugs@googlegroups.com,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
"open list:NETWORKING \[GENERAL\]" <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH v3] net/bluetooth: Fix slab-out-of-bounds read in hci_extended_inquiry_result_evt()
Date: Fri, 10 Jul 2020 19:08:51 +0200 [thread overview]
Message-ID: <43E6945B-1FFE-4283-9F1B-E84AFDCB528F@holtmann.org> (raw)
In-Reply-To: <20200710160915.228980-1-yepeilin.cs@gmail.com>
Hi Peilin,
> Check upon `num_rsp` is insufficient. A malformed event packet with a
> large `num_rsp` number makes hci_extended_inquiry_result_evt() go out
> of bounds. Fix it.
>
> This patch fixes the following syzbot bug:
>
> https://syzkaller.appspot.com/bug?id=4bf11aa05c4ca51ce0df86e500fce486552dc8d2
>
> Reported-by: syzbot+d8489a79b781849b9c46@syzkaller.appspotmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
> ---
> Change in v3:
> - Minimum `skb->len` requirement was 1 byte inaccurate since `info`
> starts from `skb->data + 1`. Fix it.
>
> Changes in v2:
> - Use `skb->len` instead of `skb->truesize` as the length limit.
> - Leave `num_rsp` as of type `int`.
>
> net/bluetooth/hci_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-10 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 5:18 [Linux-kernel-mentees] [PATCH] net/bluetooth: Fix slab-out-of-bounds read in hci_extended_inquiry_result_evt() Peilin Ye
2020-07-09 13:02 ` [Linux-kernel-mentees] [PATCH v2] " Peilin Ye
2020-07-10 10:43 ` Greg KH
2020-07-10 16:09 ` [Linux-kernel-mentees] [PATCH v3] " Peilin Ye
2020-07-10 17:08 ` Marcel Holtmann [this message]
2021-07-01 15:39 ` maybe similar bug exists for HCI_EV_INQUIRY_RESULT* like [Linux-kernel-mentees] [PATCH v2] net/bluetooth: " Alexander Larkin
2021-07-01 21:06 ` Peilin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43E6945B-1FFE-4283-9F1B-E84AFDCB528F@holtmann.org \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).