From: Joe Perches <joe@perches.com>
To: Aditya <yashsri421@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, dwaipayanray1@gmail.com
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: fix false positive for REPEATED_WORD warning
Date: Wed, 21 Oct 2020 12:26:19 -0700 [thread overview]
Message-ID: <5bacf91085ce7e253b2697333dc8ff0378fcfae9.camel@perches.com> (raw)
In-Reply-To: <0562c42d-f9af-1141-ab77-8abb73bfd31f@gmail.com>
On Thu, 2020-10-22 at 00:40 +0530, Aditya wrote:
> On 21/10/20 8:48 pm, Joe Perches wrote:
> > On Wed, 2020-10-21 at 20:31 +0530, Aditya Srivastava wrote:
> > > Presence of hexadecimal address or symbol results in false warning
> > > message by checkpatch.pl.
> > >
> > > For example, running checkpatch on commit b8ad540dd4e4 ("mptcp: fix
> > > memory leak in mptcp_subflow_create_socket()") results in warning:
> > >
> > > WARNING:REPEATED_WORD: Possible repeated word: 'ff'
> > > 00 00 00 00 00 00 00 00 00 2f 30 0a 81 88 ff ff ........./0.....
> >
> > Right.
> >
> > > To avoid all such reports, add an additional regex check for a repeating
> > > pattern of 4 or more 2-lettered words separated by space in a line.
> > > A quick evaluation on v5.6..v5.8 showed that this fix reduces
> > > REPEATED_WORD warnings from 2797 to 1043.
> >
> > Are many of the other 1043 false positives?
> > Any pattern to them?
> >
> Apart from the changes suggested by Dwaipayan in
> https://lore.kernel.org/linux-kernel-mentees/20201017162732.152351-1-dwaipayanray1@gmail.com/
>
> The 'ls -l' output seems to be another common false positive for
> REPEATED_WORD (Frequency 106 over v5.6..v5.8). For eg.
>
> WARNING:REPEATED_WORD: Possible repeated word: 'root'
> #18:
> drwxr-xr-x. 2 root root 0 Apr 17 10:53 .
[]
> @@ -3050,8 +3050,10 @@ sub process {
> }
> }
>
> - if ($rawline =~ /^\+/ || $in_commit_log) {
> + if (($rawline =~ /^\+/ || $in_commit_log) &&
> + $rawline !~ /\b[a-z-]+.* \d{1,3} [a-zA-Z]+ \w+ +\d+ \w{3} \d{1,2}
> \d{1,2}:\d{1,2}/) {
Perhaps a regex for permissions is good enough
$line !~ /\b[cbdl-][rwxs-]{9,9}\b/
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-21 22:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 15:01 [Linux-kernel-mentees] [PATCH] checkpatch: fix false positive for REPEATED_WORD warning Aditya Srivastava
2020-10-21 15:08 ` Lukas Bulwahn
2020-10-21 15:18 ` Joe Perches
2020-10-21 15:28 ` Joe Perches
2020-10-21 16:50 ` Joe Perches
2020-10-21 16:59 ` Dwaipayan Ray
2020-10-21 17:17 ` Joe Perches
2020-10-21 17:55 ` Aditya
2020-10-21 18:05 ` Joe Perches
2020-10-21 18:25 ` Aditya
2020-10-21 19:12 ` Lukas Bulwahn
2020-10-22 14:21 ` Aditya
2020-10-22 14:35 ` Joe Perches
2020-10-21 19:10 ` Aditya
2020-10-21 19:26 ` Joe Perches [this message]
2020-10-21 20:36 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2020-10-21 14:44 Aditya Srivastava
2020-10-21 14:50 ` Lukas Bulwahn
2020-10-21 5:00 Aditya Srivastava
2020-10-21 5:15 ` Aditya
2020-10-21 6:12 ` Lukas Bulwahn
2020-10-21 8:20 ` Dwaipayan Ray
2020-10-21 8:35 ` Aditya
2020-10-21 8:52 ` Lukas Bulwahn
2020-10-21 12:09 ` Aditya
2020-10-21 12:53 ` Aditya
2020-10-21 12:58 ` Lukas Bulwahn
2020-10-21 12:59 ` Dwaipayan Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bacf91085ce7e253b2697333dc8ff0378fcfae9.camel@perches.com \
--to=joe@perches.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).