From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Daniel Vetter <daniel@ffwll.ch>,
Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <treding@nvidia.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.
Date: Mon, 07 Sep 2020 21:58:44 +1000 [thread overview]
Message-ID: <6161b96a30e51ff77a387a71eee6a46400530155.camel@kernel.crashing.org> (raw)
In-Reply-To: <20200907075559.GN2352366@phenom.ffwll.local>
On Mon, 2020-09-07 at 09:55 +0200, Daniel Vetter wrote:
> On Thu, Aug 06, 2020 at 12:52:54PM +0530, Vaibhav Gupta wrote:
> > Linux Kernel Mentee: Remove Legacy Power Management.
> >
> > The original goal of the patch series is to upgrade the power
> > management
> > framework of radeonfb fbdev driver. This has been done by upgrading
> > .suspend()
> > and .resume() callbacks.
> >
> > The upgrade makes sure that the involvement of PCI Core does not
> > change the
> > order of operations executed in a driver. Thus, does not change its
> > behavior.
> >
> > During this process, it was found that "#if defined(CONFIG_PM)" at
> > line 1434 is
> > redundant. This was introduced in the commit
> > 42ddb453a0cd ("radeon: Conditionally compile PM code").
>
> I do wonder whether it wouldn't be better to just outright delete
> these,
> we have the drm radeon driver for pretty much all the same hardware
> ...
The only thing is, afaik, the DRM drivers never got the D2/D3 code that
I wrote for radeonfb to get old powerbooks to suspend/resume.
Cheers,
Ben.
> -Daniel
>
> >
> > ------------
> >
> > Before 42ddb453a0cd:
> > $ git show 65122f7e80b5:drivers/video/aty/radeon_pm.c | grep -n
> > "#ifdef\|#if\|#else\|#endif\|#elif\|#ifndef"
> >
> > Based on output in terminal:
> >
> > 547:#ifdef CONFIG_PM
> > |-- 959:#ifdef CONFIG_PPC_PMAC
> > |-- 972:#endif
> > |-- 1291:#ifdef CONFIG_PPC_OF
> > |-- 1301:#endif /* CONFIG_PPC_OF */
> > |-- 1943:#ifdef CONFIG_PPC_OF
> > |-- 2206:#if 0 /* Not ready yet */
> > |-- 2508:#endif /* 0 */
> > |-- 2510:#endif /* CONFIG_PPC_OF */
> > |-- 2648:#ifdef CONFIG_PPC_PMAC
> > |-- 2654:#endif /* CONFIG_PPC_PMAC */
> > |-- 2768:#ifdef CONFIG_PPC_PMAC
> > |-- 2774:#endif /* CONFIG_PPC_PMAC */
> > |-- 2791:#ifdef CONFIG_PPC_OF__disabled
> > |-- 2801:#endif /* CONFIG_PPC_OF */
> > 2803:#endif /* CONFIG_PM */
> >
> > ------------
> >
> > After 42ddb453a0cd:
> > $ git show 42ddb453a0cd:drivers/video/aty/radeon_pm.c | grep -n
> > "#ifdef\|#if\|#else\|#endif\|#elif\|#ifndef"
> >
> > Based on output in terminal:
> >
> > 547:#ifdef CONFIG_PM
> > |-- 959:#ifdef CONFIG_PPC_PMAC
> > |-- 972:#endif
> > |-- 1291:#ifdef CONFIG_PPC_OF
> > |-- 1301:#endif /* CONFIG_PPC_OF */
> > |-- 1430:#if defined(CONFIG_PM)
> > |-- 1431:#if defined(CONFIG_X86) ||
> > defined(CONFIG_PPC_PMAC)
> > |-- 1944:#endif
> > |-- 1946:#ifdef CONFIG_PPC_OF
> > |-- 1947:#ifdef CONFIG_PPC_PMAC
> > |-- 2208:#endif
> > |-- 2209:#endif
> > |-- 2211:#if 0 /* Not ready yet */
> > |-- 2513:#endif /* 0 */
> > |-- 2515:#endif /* CONFIG_PPC_OF */
> > |-- 2653:#ifdef CONFIG_PPC_PMAC
> > |-- 2659:#endif /* CONFIG_PPC_PMAC */
> > |-- 2773:#ifdef CONFIG_PPC_PMAC
> > |-- 2779:#endif /* CONFIG_PPC_PMAC */
> > |-- 2796:#ifdef CONFIG_PPC_OF__disabled
> > |-- 2806:#endif /* CONFIG_PPC_OF */
> > 2808:#endif /* CONFIG_PM */
> >
> > ------------
> >
> > This also affected the CONFIG_PPC_OF container (line 1943 at commit
> > 65122f7e80b5)
> >
> > The patch-series fixes it along with PM upgrade.
> >
> > All patches are compile-tested only.
> >
> > Test tools:
> > - Compiler: gcc (GCC) 10.1.0
> > - allmodconfig build: make -j$(nproc) W=1 all
> >
> > Vaibhav Gupta (2):
> > video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM
> > container
> > fbdev: radeonfb:use generic power management
> >
> > drivers/video/fbdev/aty/radeon_base.c | 10 ++++---
> > drivers/video/fbdev/aty/radeon_pm.c | 38 ++++++++++++++++++++---
> > ----
> > drivers/video/fbdev/aty/radeonfb.h | 3 +--
> > 3 files changed, 35 insertions(+), 16 deletions(-)
> >
> > --
> > 2.27.0
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-07 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 7:22 [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups Vaibhav Gupta
2020-08-06 7:26 ` Vaibhav Gupta
2020-08-06 7:26 ` [Linux-kernel-mentees] [PATCH v1 1/2] video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container Vaibhav Gupta
2020-09-07 6:33 ` Vaibhav Gupta
2020-09-07 6:48 ` Greg KH
2020-09-07 6:52 ` Vaibhav Gupta
2020-08-06 7:26 ` [Linux-kernel-mentees] [PATCH v1 2/2] fbdev: radeonfb:use generic power management Vaibhav Gupta
2020-09-07 6:34 ` Vaibhav Gupta
2020-09-07 6:31 ` [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups Vaibhav Gupta
2020-09-07 6:47 ` Greg KH
2020-09-07 7:55 ` Daniel Vetter
2020-09-07 9:16 ` Vaibhav Gupta
2020-09-07 17:57 ` Daniel Vetter
2020-09-07 10:29 ` Michel Dänzer
2020-09-07 11:58 ` Benjamin Herrenschmidt [this message]
[not found] <CGME20200907070432eucas1p27ce44eec5f3eaf3644c868c7a965ee74@eucas1p2.samsung.com>
2020-09-07 7:02 ` Vaibhav Gupta
2020-09-08 11:37 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6161b96a30e51ff77a387a71eee6a46400530155.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).