From: Kalle Valo <kvalo@kernel.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel-mentees
<linux-kernel-mentees@lists.linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: Fix UAF in ieee80211_scan_rx()
Date: Tue, 26 Jul 2022 12:55:06 +0300 [thread overview]
Message-ID: <8735eomc5h.fsf@kernel.org> (raw)
In-Reply-To: <20220701145423.53208-1-code@siddh.me> (Siddh Raman Pant's message of "Fri, 1 Jul 2022 20:24:23 +0530")
Siddh Raman Pant <code@siddh.me> writes:
> ieee80211_scan_rx() tries to access scan_req->flags after a null check
> (see line 303 of mac80211/scan.c), but ___cfg80211_scan_done() uses
> kfree() on the scan_req (see line 991 of wireless/scan.c).
>
> This results in a UAF.
>
> ieee80211_scan_rx() is called inside a RCU read-critical section
> initiated by ieee80211_rx_napi() (see line 5043 of mac80211/rx.c).
>
> Thus, add an rcu_head to the scan_req struct so as to use kfree_rcu()
> instead of kfree() so that we don't free during the critical section.
>
> Bug report (3): https://syzkaller.appspot.com/bug?extid=f9acff9bf08a845f225d
> Reported-by: syzbot+f9acff9bf08a845f225d@syzkaller.appspotmail.com
> Reported-by: syzbot+6cb476b7c69916a0caca@syzkaller.appspotmail.com
> Reported-by: syzbot+9250865a55539d384347@syzkaller.appspotmail.com
>
> Signed-off-by: Siddh Raman Pant <code@siddh.me>
> ---
> include/net/cfg80211.h | 2 ++
> net/wireless/scan.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
The title should be:
wifi: cfg80211: Fix UAF in ieee80211_scan_rx()
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-07-26 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 14:54 [PATCH] net: Fix UAF in ieee80211_scan_rx() Siddh Raman Pant
2022-07-07 11:36 ` Ping: " Siddh Raman Pant via Linux-kernel-mentees
2022-07-07 11:50 ` Greg KH
2022-07-07 11:59 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-26 9:55 ` Kalle Valo [this message]
2022-07-26 11:50 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-26 10:07 ` Eric Dumazet via Linux-kernel-mentees
2022-07-26 12:16 ` Siddh Raman Pant via Linux-kernel-mentees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735eomc5h.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=code@siddh.me \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).