From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH v4] checkpatch: add new warnings to author signoff checks.
Date: Wed, 7 Oct 2020 00:31:08 +0530 [thread overview]
Message-ID: <CABJPP5Awe=CDC7riYBBVDf9WRO4aAMXK2QROYdtGyJXNjqB-ew@mail.gmail.com> (raw)
In-Reply-To: <8553d6679f97ae9d285a9ffd61198f5e3c11dc35.camel@perches.com>
On Wed, Oct 7, 2020 at 12:25 AM Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2020-10-07 at 00:21 +0530, Dwaipayan Ray wrote:
> > The author signed-off-by checks are currently very vague.
> > Cases like same name or same address are not handled separately.
> >
> > For example, running checkpatch on commit be6577af0cef
> > ("parisc: Add atomic64_set_release() define to avoid CPU soft lockups"),
> > gives:
>
> Aren't you still missing emitting an message for cases like
>
> From: "J. Random Developer" <jrd@bigcorp.com>
> [...]
> Signed-off-by: "J. Random Developer" (BigCorp) <jrd@bigcorp.com>
>
> Where a comment does not match?
>
>
Yes, messages for comments were not emitted previously too
cause the same_email_address() function just matches name
and email (discarding name comments and email comments).
So should I add it to this patch, or should I work on it in a different
patch perhaps because it involves change on another subroutine?
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-06 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 18:51 [Linux-kernel-mentees] [PATCH v4] checkpatch: add new warnings to author signoff checks Dwaipayan Ray
2020-10-06 18:55 ` Joe Perches
2020-10-06 19:01 ` Dwaipayan Ray [this message]
2020-10-06 20:09 ` Joe Perches
2020-10-06 20:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABJPP5Awe=CDC7riYBBVDf9WRO4aAMXK2QROYdtGyJXNjqB-ew@mail.gmail.com' \
--to=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).