From: Dwaipayan Ray <dwaipayanray1@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: add new exception to repeated word check
Date: Wed, 14 Oct 2020 22:03:35 +0530 [thread overview]
Message-ID: <CABJPP5Cp7LNJhhNTtpoHidZEO1nXWL-+ZWijvOJ9EVQ4_cK_ng@mail.gmail.com> (raw)
In-Reply-To: <eb7e86171263a27e5c761bddf91439a5ec8c83e1.camel@perches.com>
On Wed, Oct 14, 2020 at 9:47 PM Joe Perches <joe@perches.com> wrote:
>
> On Wed, 2020-10-14 at 19:26 +0530, Dwaipayan Ray wrote:
> > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > moved the repeated word test to check for more file types. But after
> > this, if checkpatch.pl is run on MAINTAINERS, it generates several
> > new warnings of the type:
> >
> > WARNING: Possible repeated word: 'git'
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3063,7 +3063,7 @@ sub process {
> > }
> >
> > next if ($first ne $second);
> > - next if ($first eq 'long');
> > + next if ($first =~ /(?:long|git)$/);
>
> Nak. This needs a leading ^ otherwise words
> like "belong" and "digit" match as well.
>
> next if ($first =~ /^(?:long|git)$/);
>
>
Yikes, that was silly of me. I will correct and send you the
updated version.
Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-14 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 13:56 [Linux-kernel-mentees] [PATCH] checkpatch: add new exception to repeated word check Dwaipayan Ray
2020-10-14 16:17 ` Joe Perches
2020-10-14 16:33 ` Dwaipayan Ray [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-13 6:30 Dwaipayan Ray
2020-10-14 10:34 ` Dwaipayan Ray
2020-10-14 11:16 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABJPP5Cp7LNJhhNTtpoHidZEO1nXWL-+ZWijvOJ9EVQ4_cK_ng@mail.gmail.com \
--to=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).