From: David Gow via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: Vitor Massaru Iha <vitor@massaru.org>
Cc: Kees Cook <keescook@chromium.org>,
Brendan Higgins <brendanhiggins@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
KUnit Development <kunit-dev@googlegroups.com>
Subject: Re: [Linux-kernel-mentees] [RFC 0/3] kunit: add support to use modules
Date: Wed, 15 Jul 2020 11:47:11 +0800 [thread overview]
Message-ID: <CABVgOSkBAiMSMzCx62_CRo_0e2SGdvRWZ0dSC4t628YJBw-3Aw@mail.gmail.com> (raw)
In-Reply-To: <20200715031120.1002016-1-vitor@massaru.org>
On Wed, Jul 15, 2020 at 11:11 AM Vitor Massaru Iha <vitor@massaru.org> wrote:
>
> Currently, KUnit does not allow the use of tests as a module.
> This prevents the implementation of tests that require userspace.
If this is what I think it is, thanks! I'll hopefully get a chance to
play with it over the next few days.
Can we clarify what this means: the current description is a little
misleading, as KUnit tests can already be built and run as modules,
and "tests that require userspace" is a bit broad.
As I understand it, this patchset does three things:
- Let kunit_tool install modules to a root filesystem and boot UML
with that filesystem.
- Have tests inherit the mm of the process that started them, which
(if the test is in a module), provides a user-space memory context so
that copy_{from,to}_user() works.
- Port the test_user_copy.c tests to KUnit, using this new feature.
A few comments from my quick glance over it:
- The rootfs support is useful: I'm curious how it'll interact with
non-UML architectures in [1]. It'd be nice for this to be extensible
and to not explicitly state UML where possible.
- The inheriting of the mm stuff still means that
copy_{from,to}_user() will only work if loaded as a module. This
really needs to be documented. (Ideally, we'd find a way of having
this work even for built-in tests, but I don't have any real ideas as
to how that could be done).
- It'd be nice to split the test_user_copy.c test port into a separate
commit. In fact, it may make sense to also split the kunit_tool
changes and the mm changes into separate series, as they're both quite
useful independently.
Cheers,
-- David
> This patchset makes this possible by introducing the use of
> the root filesystem in KUnit. And it allows the use of tests
> that can be compiled as a module
>
> Vitor Massaru Iha (3):
> kunit: tool: Add support root filesystem in kunit-tool
> lib: Allows to borrow mm in userspace on KUnit
> lib: Convert test_user_copy to KUnit test
>
> include/kunit/test.h | 1 +
> lib/Kconfig.debug | 17 ++
> lib/Makefile | 2 +-
> lib/kunit/try-catch.c | 15 +-
> lib/{test_user_copy.c => user_copy_kunit.c} | 196 +++++++++-----------
> tools/testing/kunit/kunit.py | 37 +++-
> tools/testing/kunit/kunit_kernel.py | 105 +++++++++--
> 7 files changed, 238 insertions(+), 135 deletions(-)
> rename lib/{test_user_copy.c => user_copy_kunit.c} (55%)
>
>
> base-commit: 725aca9585956676687c4cb803e88f770b0df2b2
> prerequisite-patch-id: 582b6d9d28ce4b71628890ec832df6522ca68de0
> --
> 2.26.2
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-15 3:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 3:11 [Linux-kernel-mentees] [RFC 0/3] kunit: add support to use modules Vitor Massaru Iha
2020-07-15 3:11 ` [Linux-kernel-mentees] [RFC 1/3] kunit: tool: Add support root filesystem in kunit-tool Vitor Massaru Iha
2020-07-16 0:29 ` Brendan Higgins via Linux-kernel-mentees
2020-07-16 16:34 ` Vitor Massaru Iha
2020-07-15 3:11 ` [Linux-kernel-mentees] [RFC 2/3] lib: Allows to borrow mm in userspace on KUnit Vitor Massaru Iha
2020-07-16 0:37 ` Brendan Higgins via Linux-kernel-mentees
2020-07-16 16:35 ` Vitor Massaru Iha
2020-07-16 16:35 ` Vitor Massaru Iha
2020-07-15 3:11 ` [Linux-kernel-mentees] [RFC 3/3] lib: Convert test_user_copy to KUnit test Vitor Massaru Iha
2020-07-16 0:40 ` Brendan Higgins via Linux-kernel-mentees
2020-07-16 16:40 ` Vitor Massaru Iha
2020-07-16 2:34 ` Kees Cook
2020-07-16 16:42 ` Vitor Massaru Iha
2020-07-15 3:47 ` David Gow via Linux-kernel-mentees [this message]
2020-07-16 2:41 ` [Linux-kernel-mentees] [RFC 0/3] kunit: add support to use modules Kees Cook
2020-07-16 16:32 ` Vitor Massaru Iha
2020-07-16 16:21 ` Vitor Massaru Iha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABVgOSkBAiMSMzCx62_CRo_0e2SGdvRWZ0dSC4t628YJBw-3Aw@mail.gmail.com \
--to=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).