From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
To: Wei Liu <wei.liu@kernel.org>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
paul@xen.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joel Fernandes <joel@joelfernandes.org>,
xen-devel@lists.xenproject.org,
linux-kernel-mentees@lists.linuxfoundation.org,
davem@davemloft.net
Subject: Re: [Linux-kernel-mentees] [PATCH] net: xen-netbank: hash.c: Use built-in RCU list checking
Date: Wed, 15 Jan 2020 21:16:21 +0530 [thread overview]
Message-ID: <CAF65HP2gnDYud99DY51JMXGKaNUC5JNZgPWB8bgno+gjoVffvA@mail.gmail.com> (raw)
In-Reply-To: <20200115150426.svapzpux2tbbgvmn@debian>
[-- Attachment #1.1: Type: text/plain, Size: 893 bytes --]
On Wed, Jan 15, 2020 at 8:34 PM Wei Liu <wei.liu@kernel.org> wrote:
> On Wed, Jan 15, 2020 at 07:36:38PM +0530, Madhuparna Bhowmik wrote:
> [...]
> >
> > > The surrounding code makes it pretty clear that the lock is already
> held
> > > by the time list_for_each_entry_rcu is called, yet the checking
> involved
> > > in lockdep_is_held is not trivial, so I'm afraid I don't consider this
> a
> > > strict improvement over the existing code.
> > >
> > > Actually, we want to make CONFIG_PROVE_LIST_RCU enabled by default.
>
> I think you meant CONFIG_PROVE_RCU_LIST.
>
> I am sorry about this. Yes, I meant CONFIG_PROVE_RCU_LIST.
> And if the cond argument is not passed when the usage of
> > list_for_each_entry_rcu()
> > is outside of rcu_read_lock(), it will lead to a false positive.
> > Therefore, I think this patch is required.
>
> Fair enough.
>
> Thank you,
Madhuparna
> Wei.
>
[-- Attachment #1.2: Type: text/html, Size: 1638 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-01-15 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 12:41 [Linux-kernel-mentees] [PATCH] net: xen-netbank: hash.c: Use built-in RCU list checking madhuparnabhowmik04
2020-01-15 13:56 ` Wei Liu
2020-01-15 14:06 ` Madhuparna Bhowmik
2020-01-15 15:04 ` Wei Liu
2020-01-15 15:46 ` Madhuparna Bhowmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF65HP2gnDYud99DY51JMXGKaNUC5JNZgPWB8bgno+gjoVffvA@mail.gmail.com \
--to=madhuparnabhowmik04@gmail.com \
--cc=davem@davemloft.net \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=paulmck@kernel.org \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).