From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Anup Sharma <anupnewsmail@gmail.com>
Cc: andy@kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
sakari.ailus@linux.intel.com, mchehab@kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>
Date: Sun, 16 Apr 2023 13:01:32 +0300 [thread overview]
Message-ID: <CAHp75Veaqp4O1jcBHZZh2L5ReMU1+2vH+FfRzfLyY8CdwZwq+w@mail.gmail.com> (raw)
In-Reply-To: <ZDuhnLPczec5qJnq@yoga>
On Sun, Apr 16, 2023 at 10:20 AM Anup Sharma <anupnewsmail@gmail.com> wrote:
>
> Fix following checkpatch.pl warning by including
> <linux/processor.h> instead of <asm/processor.h>
Missing period at the end. But the entire patch seems unnecessary
since it's all about x86, and we have more arch headers there anyway.
Anyway it's up to Hans. Also see below.
...
> #include <asm/intel-family.h>
> -#include <asm/processor.h>
> +#include <linux/processor.h>
>
> #include <linux/i2c.h>
> #include <media/v4l2-subdev.h>
This seems a bit chaotic with the ordering of the headers here.
...
If you want a good patch, you need to understand what headers are
_really_ being used in the header file. Then drop unused, try to
compile that and fix all files that will have missing headers after
that. This will be a very useful clean up!
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next parent reply other threads:[~2023-04-16 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZDuhnLPczec5qJnq@yoga>
2023-04-16 10:01 ` Andy Shevchenko [this message]
2023-04-16 13:08 ` [PATCH] Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h> Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Veaqp4O1jcBHZZh2L5ReMU1+2vH+FfRzfLyY8CdwZwq+w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=anupnewsmail@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).