From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Nachiket Naganure <nachiketun8@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] Checkpatch: Disables commit length check/warning in commit log in case of valid signature tags
Date: Sun, 19 Jul 2020 19:36:50 +0200 [thread overview]
Message-ID: <CAKXUXMx3pkpY9Ud=VRf5EVVpr2ThvBTyF9Lr6Hw+CCRFvO7AbQ@mail.gmail.com> (raw)
In-Reply-To: <20200719171554.264462-1-nachiketun8@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1113 bytes --]
Did you checkpatch this patch?
You need to provide a rationale. Use a full checkpatch.pl evaluation data
for showing the difference before and after applying the patch.
Lukas
On So., 19. Juli 2020 at 19:16, Nachiket Naganure <nachiketun8@gmail.com>
wrote:
> From: NachiketUN <nachiketun8@gmail.com>
>
> Signed-off-by: NachiketUN <nachiketun8@gmail.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 197436b20288..8db0f26601c5 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2799,7 +2799,7 @@ sub process {
>
> # Check for line lengths > 75 in commit log, warn once
> if ($in_commit_log && !$commit_log_long_line &&
> - length($line) > 75 &&
> + length($line) > 75 && $line !~ /$signature_tags/ &&
> !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
> # file delta changes
> $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
> --
> 2.25.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 2159 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-19 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 17:15 [Linux-kernel-mentees] [PATCH] Checkpatch: Disables commit length check/warning in commit log in case of valid signature tags Nachiket Naganure
2020-07-19 17:36 ` Lukas Bulwahn [this message]
2020-07-20 12:22 ` Nachiket N
2020-07-20 16:23 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMx3pkpY9Ud=VRf5EVVpr2ThvBTyF9Lr6Hw+CCRFvO7AbQ@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=nachiketun8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).