From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: Linux Kernel: Checkpatch Documentation Mentorship Tasks
Date: Tue, 3 Aug 2021 20:07:41 +0200 [thread overview]
Message-ID: <CAKXUXMy2V9GJM+h1cEeHSTUsKQ3b=MfXY_jba3FRDNKKo12iRA@mail.gmail.com> (raw)
In-Reply-To: <20210803163602.GA3469@uver-laptop>
On Tue, Aug 3, 2021 at 6:36 PM Utkarsh Verma <utkarshverma294@gmail.com> wrote:
>
> On Mon, Jul 26, 2021 at 12:40:48PM +0200, Lukas Bulwahn wrote:
> >
> > On Sun, Jul 25, 2021 at 12:06 AM Utkarsh Verma
> > <utkarshverma294@gmail.com> wrote:
> > >
> > > On Sat, Jul 17, 2021 at 09:23:19AM +0200, Lukas Bulwahn wrote:
> > > > Get a clone of the Linux kernel repository. The script checkpatch.pl
> > > > is under the scripts directory.
> > > >
>
> (snip)
>
> > >
> > > drivers/usb/serial/iuu_phoenix.c:1191: WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> > > drivers/usb/serial/iuu_phoenix.c:1194: WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> > > drivers/usb/serial/iuu_phoenix.c:1197: WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> > > drivers/usb/serial/iuu_phoenix.c:1201: WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> > > drivers/usb/serial/iuu_phoenix.c:1205: WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'.
> > >
> > > The file permission macros used in the kernel code are defined in
> > > <linux/stat.h> like S_IRUGO and friends. But it is better to use their
> > > octal equivalent instead, because it easier for Linux users to
> > > understand 0444 instead of S_IRUGO.
> > >
> > > There is no checkpatch documentation for this warning message, but the
> > > message is self explanatory.
> > >
> >
> > Please provide a patch for the checkpatch documentation here. Do you
> > find a reference to some coding style guide in the kernel or some
> > discussion on the mailing list that stated the preference you wrote
> > here?
> >
>
> Yes, Linus suggested the tree-wide conversions for using octal permission.
> https://lwn.net/Articles/696229/
>
Well, then add that reference to your patch on checkpatch
documentation. Waiting for your v2.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-08-03 18:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 6:46 Linux Kernel: Checkpatch Documentation Mentorship Tasks Utkarsh Verma
2021-07-17 7:23 ` Lukas Bulwahn
2021-07-24 22:06 ` Utkarsh Verma
2021-07-26 10:40 ` Lukas Bulwahn
2021-08-03 14:17 ` [PATCH] Documentation: checkpatch: Add SPLIT_STRING message Utkarsh Verma
2021-08-03 14:52 ` Dwaipayan Ray
2021-08-03 18:13 ` Utkarsh Verma
2021-08-03 18:20 ` Lukas Bulwahn
2021-08-04 18:09 ` [PATCH v2] " Utkarsh Verma
2021-08-03 14:19 ` [PATCH] Documentation: checkpatch: Add SYMBOLIC_PERMS message Utkarsh Verma
2021-08-03 14:20 ` [PATCH] Documentation: checkpatch: Add TRAILING_SEMICOLON message Utkarsh Verma
2021-08-03 15:20 ` Dwaipayan Ray
2021-08-03 21:19 ` [PATCH v2] " Utkarsh Verma
2021-08-05 13:49 ` Dwaipayan Ray
2021-08-20 19:53 ` [PATCH v3] " Utkarsh Verma
2021-08-22 17:29 ` Dwaipayan Ray
2021-08-03 14:20 ` [PATCH] USB: serial: iuu_phoenix: fix checkpatch memset warning Utkarsh Verma
2021-08-03 14:21 ` [PATCH] USB: serial: iuu_phoenix: fix quoted string split across lines Utkarsh Verma
2021-08-05 13:52 ` Dwaipayan Ray
2021-08-05 14:20 ` Lukas Bulwahn
2021-08-06 13:12 ` Utkarsh Verma
2021-08-25 8:22 ` [PATCH v2] " Utkarsh Verma
2021-08-03 14:21 ` [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions Utkarsh Verma
2021-08-03 18:11 ` Lukas Bulwahn
2021-08-03 18:37 ` [PATCH v2] " Utkarsh Verma
2021-08-20 10:09 ` Lukas Bulwahn
2021-08-20 19:08 ` Utkarsh Verma
2021-08-04 19:12 ` [PATCH] " Utkarsh Verma
2021-08-05 9:26 ` Lukas Bulwahn
2021-08-06 19:12 ` Utkarsh Verma
2021-08-03 16:36 ` Linux Kernel: Checkpatch Documentation Mentorship Tasks Utkarsh Verma
2021-08-03 18:07 ` Lukas Bulwahn [this message]
2021-08-03 21:37 ` [PATCH v2] Documentation: checkpatch: Add SYMBOLIC_PERMS message Utkarsh Verma
2021-08-03 21:49 ` Dwaipayan Ray
2021-08-04 15:31 ` [PATCH v3] " Utkarsh Verma
2021-08-05 13:51 ` Dwaipayan Ray
2021-08-06 13:46 ` Utkarsh Verma
2021-08-06 19:56 ` Dwaipayan Ray
2021-08-06 20:03 ` Lukas Bulwahn
2021-08-06 20:10 ` [PATCH v4] " Utkarsh Verma
2021-08-22 17:52 ` Dwaipayan Ray
2021-08-23 7:18 ` Lukas Bulwahn
2021-08-24 22:13 ` [PATCH v5] " Utkarsh Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMy2V9GJM+h1cEeHSTUsKQ3b=MfXY_jba3FRDNKKo12iRA@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=utkarshverma294@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).