From: Greg KH <gregkh@linuxfoundation.org>
To: Siddh Raman Pant <code@siddh.me>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Jarkko Sakkinen <jarkko@kernel.org>,
James Morris <jmorris@namei.org>,
David Howells <dhowells@redhat.com>,
linux-security-modules <linux-security-module@vger.kernel.org>,
keyrings <keyrings@vger.kernel.org>,
linux-kernel-mentees
<linux-kernel-mentees@lists.linuxfoundation.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree
Date: Sat, 23 Jul 2022 16:05:16 +0200 [thread overview]
Message-ID: <YtwAHGISvlgXgXZM@kroah.com> (raw)
In-Reply-To: <20220723135035.199188-1-code@siddh.me>
On Sat, Jul 23, 2022 at 07:20:35PM +0530, Siddh Raman Pant via Linux-kernel-mentees wrote:
> In keyctl_watch_key, use kfree_rcu() for freeing watch and wlist
> as they support RCU and have an rcu_head in the struct definition.
That does not explain why this change is needed. What problem does this
solve? Why use RCU if you don't have to? What functionality did you
just change in this commit and why?
And how was this tested?
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-07-23 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 13:50 [PATCH] keys/keyctl: Use kfree_rcu instead of kfree Siddh Raman Pant via Linux-kernel-mentees
2022-07-23 14:05 ` Greg KH [this message]
2022-07-23 14:35 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-23 14:43 ` Greg KH
2022-07-23 15:28 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-23 14:50 ` James Bottomley
2022-07-23 15:28 ` Siddh Raman Pant via Linux-kernel-mentees
2022-07-28 8:11 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtwAHGISvlgXgXZM@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=code@siddh.me \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).