From: Coleman Dietsch <dietschc@csp.edu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com,
Dave Hansen <dave.hansen@linux.intel.com>,
kvm@vger.kernel.org, Sean Christopherson <seanjc@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] KVM: x86/xen: Fix bug in kvm_xen_vcpu_set_attr()
Date: Fri, 29 Jul 2022 18:29:07 -0500 [thread overview]
Message-ID: <YuRtQ/GHc3poAmHG@kernel-dev-1> (raw)
In-Reply-To: <YuOPDpy+RqD09n3j@kroah.com>
On Fri, Jul 29, 2022 at 09:41:02AM +0200, Greg KH wrote:
> On Thu, Jul 28, 2022 at 02:47:37PM -0500, Coleman Dietsch wrote:
> > This crash appears to be happening when vcpu->arch.xen.timer is already set and kvm_xen_init_timer(vcpu) is called.
>
> What does "this crash" refer to ?
>
> >
> > During testing with the syzbot reproducer code it seemed apparent that the else if statement in the KVM_XEN_VCPU_ATTR_TYPE_TIMER switch case was not being reached, which is where the kvm_xen_stop_timer(vcpu) call is located.
>
> Please properly wrap your kernel changelog at 72 columns.
>
> Didn't checkpatch.pl complain about this?
>
I believe I made the mistake of editing the patch file directly so it was
on me for forgetting to run checkpatch.pl manually.
> thanks,
>
> greg k-h
Thanks for the feedback Greg, I believe I have (at least these) issues
resolved in the next version of the patch.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2022-07-29 23:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:47 [PATCH] KVM: x86/xen: Fix bug in kvm_xen_vcpu_set_attr() Coleman Dietsch
2022-07-28 20:41 ` Sean Christopherson via Linux-kernel-mentees
2022-07-28 22:49 ` Coleman Dietsch
2022-07-29 7:41 ` Greg KH
2022-07-29 23:29 ` Coleman Dietsch [this message]
2022-08-08 13:51 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuRtQ/GHc3poAmHG@kernel-dev-1 \
--to=dietschc@csp.edu \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paskripkin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).