From: Julia Lawall <julia.lawall@inria.fr>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr
Subject: Re: [Linux-kernel-mentees] [PATCH] parsing_hacks: Add bool to list of known typedefs
Date: Tue, 21 Jan 2020 06:23:30 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2001210622150.2301@hadrien> (raw)
In-Reply-To: <20200119134812.32748-1-jaskaransingh7654321@gmail.com>
On Sun, 19 Jan 2020, Jaskaran Singh wrote:
> bool is widely used in the Linux kernel. Certain cases of
> parsing_hacks.ml would mislabel bool.
>
> Add bool to the list of known typedefs.
As far as I can see, this function is only used for avoiding to print some
warning messages. So I'm not sure why it would have any impact on the
parsing at all?
julia
> Stats of --parse-c on Linux v5.5-rc4 are as follows:
>
> Before:
>
> nb good = 18956150, nb passed = 134062 =========> 0.70% passed
>
> After:
>
> nb good = 18956150, nb passed = 134073 =========> 0.70% passed
>
> Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
> ---
> The above diff has been obtained after applying
> https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06706.html
>
> parsing_c/parsing_hacks.ml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/parsing_c/parsing_hacks.ml b/parsing_c/parsing_hacks.ml
> index 685a4908..5e3301a0 100644
> --- a/parsing_c/parsing_hacks.ml
> +++ b/parsing_c/parsing_hacks.ml
> @@ -61,7 +61,7 @@ let is_known_typdef =
> | "u_char" | "u_short" | "u_int" | "u_long"
> | "u8" | "u16" | "u32" | "u64"
> | "s8" | "s16" | "s32" | "s64"
> - | "__u8" | "__u16" | "__u32" | "__u64"
> + | "__u8" | "__u16" | "__u32" | "__u64" | "bool"
> -> true
>
> | "acpi_handle"
> --
> 2.21.1
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-01-21 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 13:48 [Linux-kernel-mentees] [PATCH] parsing_hacks: Add bool to list of known typedefs Jaskaran Singh
2020-01-21 6:20 ` Julia Lawall
2020-01-21 6:27 ` Jaskaran Singh
2020-01-21 6:30 ` Julia Lawall
2020-01-21 6:23 ` Julia Lawall [this message]
2020-01-21 6:31 ` Jaskaran Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001210622150.2301@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=jaskaransingh7654321@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).