From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Nachiket Naganure <nachiketun8@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] Checkpatch: Disable commit log length check warning for signature tag
Date: Mon, 27 Jul 2020 07:39:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2007270735130.19509@felia> (raw)
In-Reply-To: <20200727050724.554063-1-nachiketun8@gmail.com>
On Mon, 27 Jul 2020, Nachiket Naganure wrote:
> Disable commit log length check in case of signature tag. If the commit
> log line has valid signature tags such as "Reported-and-tested-by" with
> more than 75 characters, suppress the long length warning.
>
> For instance in commit ac854131d984 ("USB: core: Fix misleading driver bug
> report"), the corresponding patch contains a "Reported by" tag line which
> exceeds 75 chars. And there is no valid way to shorten the length.
>
> Signed-off-by: Nachiket Naganure <nachiketun8@gmail.com>
It looks more sound now. It applies cleanly on next-20200724, and it
addresses the false positive in the mentioned commit.
The commit message header is still wrong.
If you run
git log --oneline ./scripts/checkpatch.pl
you will see that all commits start with lower-case "checkpatch:" and very
often, it continues with lower-case after the colon.
Fix that and send it out to intended recipients using get_maintainers.pl,
also CC the kernel-mentees list, Shuah and me.
Lukas
> ---
> scripts/checkpatch.pl | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 197436b20288..46237e9e0550 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2806,6 +2806,8 @@ sub process {
> # filename then :
> $line =~ /^\s*(?:Fixes:|Link:)/i ||
> # A Fixes: or Link: line
> + $line =~ /$signature_tags/ ||
> + # Check for signature_tags
> $commit_log_possible_stack_dump)) {
> WARN("COMMIT_LOG_LONG_LINE",
> "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
> --
> 2.25.1
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-27 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 5:07 [Linux-kernel-mentees] [PATCH v2] Checkpatch: Disable commit log length check warning for signature tag Nachiket Naganure
2020-07-27 5:39 ` Lukas Bulwahn [this message]
2020-07-28 11:29 [Linux-kernel-mentees] [PATCH v2] checkpatch: disable " Nachiket Naganure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2007270735130.19509@felia \
--to=lukas.bulwahn@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=nachiketun8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).