From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] Linux kernel checkpatch.pl mentorship
Date: Thu, 17 Sep 2020 17:03:39 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2009171654520.9985@felia> (raw)
In-Reply-To: <CABJPP5CQc8WMQU2yLbW9OVrd8bdDNFJsKTqjonOsqQHCk5G1TA@mail.gmail.com>
On Thu, 17 Sep 2020, Dwaipayan Ray wrote:
> > Good investigation. Can you please share the commit of the commit message
> > you refer to in the future?
> >
> > I found it, commit cd2614967d8b ("checkpatch: warn if missing author
> > Signed-off-by"), but to convince the maintainers and authors that you did
> > your homework properly, it is good to refer to the commits you looked at.
> >
> > The kernel documentation tells you how to refer to commits.
> >
>
> Yes sure, I will remember to do that in the future.
>
> For now, I am thinking to fix the split FROM header issue. What I have thought
> of is to keep a variable keeping the part data and if the author cannot be
> resolved at the present line, then at the next line join the data and parse
> the email.
> I think the implementation to this will be fairly easy, with one
> flag variable to indicate whether the from header has been parsed in the
> previous line.
>
> Should i proceed with this?
>
Sure. I suggest you just have a look at how checkpatch.pl handles rules
when content is split over multiple lines, though. I think Ayush copied
one typical pattern of checking the current line and the next line.
I will trust you that you will find a solution that works...
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-17 15:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABJPP5CSa_QowD-O3_E5ndoQJvuBv=n2x5WG-acwQKE=rt5+Rw@mail.gmail.com>
[not found] ` <alpine.DEB.2.21.2009110925160.9220@felia>
2020-09-12 9:09 ` [Linux-kernel-mentees] Linux kernel checkpatch.pl mentorship Dwaipayan Ray
2020-09-12 11:03 ` Lukas Bulwahn
2020-09-12 12:08 ` Dwaipayan Ray
2020-09-12 12:21 ` Lukas Bulwahn
2020-09-13 8:16 ` Dwaipayan Ray
2020-09-13 11:05 ` Lukas Bulwahn
[not found] ` <CABJPP5BmRcC+OTSjuX_QrYononVq__DkhjGOgiKrP147MAXK+g@mail.gmail.com>
[not found] ` <alpine.DEB.2.21.2009132015570.6806@felia>
2020-09-13 18:23 ` Dwaipayan Ray
[not found] ` <alpine.DEB.2.21.2009132010300.6806@felia>
2020-09-13 18:39 ` Dwaipayan Ray
2020-09-14 5:17 ` Lukas Bulwahn
2020-09-14 12:31 ` Dwaipayan Ray
2020-09-14 13:49 ` Lukas Bulwahn
2020-09-14 15:39 ` Dwaipayan Ray
2020-09-14 18:32 ` Lukas Bulwahn
2020-09-15 13:04 ` Dwaipayan Ray
2020-09-16 7:01 ` Lukas Bulwahn
2020-09-17 13:09 ` Dwaipayan Ray
2020-09-17 13:41 ` Dwaipayan Ray
2020-09-17 14:18 ` Lukas Bulwahn
2020-09-17 14:43 ` Dwaipayan Ray
2020-09-17 15:03 ` Lukas Bulwahn [this message]
2020-09-17 14:13 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2009171654520.9985@felia \
--to=lukas.bulwahn@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).