From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
Cc: Michal Marek <michal.lkml@markovi.net>,
linux-ia64@vger.kernel.org, Kees Cook <keescook@chromium.org>,
linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Linux-kernel-mentees] [PATCH RFC 0/2] use interpreters to invoke scripts
Date: Sun, 4 Oct 2020 08:51:36 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2010040809230.28226@felia> (raw)
In-Reply-To: <2b00e566-112c-5657-c10f-7f210d3eae93@gmail.com>
On Sat, 3 Oct 2020, Ujjwal Kumar wrote:
> This patch series aims at removing the dependency on execute
> bit of the scripts in the kbuild system.
>
Ujjwal, your setup to send out the patch series created three unrelated
emails rather than the default way, i.e., to have one cover letter
and the patches in reply to the cover letter.
You can see the difference here:
https://lore.kernel.org/linux-kbuild/
The presentation of your patch series looks different than the other
patch series on the list. Use the linux-kernel-mentees list for testing
your setup.
For this version of the patch series, I guess it is okay; but this set up
right for the next patch series.
> If not working with fresh clone of linux-next, clean the srctree:
> make distclean
> make tools/clean
>
I hit an unrelated issue on next-20201002 that make tools/clean fails.
Other than that, this is all good.
> To test the dependency on execute bits, I tried building the
> kernel after removing x-bits for all files in the repository.
> Removing execute bits:
> for i in $(find -executable -type f); do chmod -x $i; done
>
Okay, I did that.
> Any attempts to configure (or build) the kernel fail because of
> 'Permission denied' on scripts with the following error:
> $ make allmodconfig
> sh: ./scripts/gcc-version.sh: Permission denied
> init/Kconfig:34: syntax error
> init/Kconfig:33: invalid statement
> init/Kconfig:34: invalid statement
> sh: ./scripts/ld-version.sh: Permission denied
> init/Kconfig:39: syntax error
> init/Kconfig:38: invalid statement
> sh: ./scripts/clang-version.sh: Permission denied
> init/Kconfig:49: syntax error
> init/Kconfig:48: invalid statement
> make[1]: *** [scripts/kconfig/Makefile:71: allmodconfig] Error 1
> make: *** [Makefile:606: allmodconfig] Error 2
>
I can confirm that these errors are reported on next-20201002.
> Changes:
> 1. Adds specific interpreters (in Kconfig) to invoke
> scripts.
>
> After this patch I could successfully do a kernel build
> without any errors.
>
With this first patch, I could then successfully do:
make allmodconfig && make
So far, so good. I did check the first patch.
Lukas
> 2. Again, adds specific interpreters to other parts of
> kbuild system.
>
> I could successfully perform the following make targets after
> applying the PATCH 2/2:
> make headerdep
> make kselftest-merge
> make rpm-pkg
> make perf-tar-src-pkg
> make ARCH=ia64 defconfig
> ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make prepare
>
> Following changes in PATCH 2/2 are not yet tested:
> arch/arm64/kernel/vdso32/Makefile
> arch/nds32/kernel/vdso/Makefile
> scripts/Makefile.build
>
> Ujjwal Kumar (2):
> kconfig: use interpreters to invoke scripts
> kbuild: use interpreters to invoke scripts
>
> Makefile | 4 ++--
> arch/arm64/kernel/vdso/Makefile | 2 +-
> arch/arm64/kernel/vdso32/Makefile | 2 +-
> arch/ia64/Makefile | 4 ++--
> arch/nds32/kernel/vdso/Makefile | 2 +-
> init/Kconfig | 16 ++++++++--------
> scripts/Makefile.build | 2 +-
> scripts/Makefile.package | 4 ++--
> 8 files changed, 18 insertions(+), 18 deletions(-)
>
> --
> 2.26.2
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-04 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 15:19 [Linux-kernel-mentees] [PATCH RFC 0/2] use interpreters to invoke scripts Ujjwal Kumar
2020-10-04 6:51 ` Lukas Bulwahn [this message]
2020-10-12 13:40 ` Lukas Bulwahn
2020-10-12 16:18 ` Masahiro Yamada
2020-10-12 16:36 ` Ujjwal Kumar
-- strict thread matches above, loose matches on Subject: below --
2020-10-02 10:38 Ujjwal Kumar
2020-10-02 21:36 ` Ujjwal Kumar
2020-10-03 6:27 ` Lukas Bulwahn
2020-10-03 6:24 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010040809230.28226@felia \
--to=lukas.bulwahn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=ujjwalkumar0501@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).