linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Joe Perches <joe@perches.com>, Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: [Linux-kernel-mentees] checkpatch.pl: REPEATED_WORD: massive false positive in MAINTAINERS
Date: Thu, 8 Oct 2020 13:50:56 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2010081247510.19461@felia> (raw)

Dear Joe, dear Dwaipayan,

while maintaining MAINTAINERS, I noticed that the REPEATED_WORD check, 
which in general is a great addition to checkpatch.pl, generates a massive
number of warnings due to one specific pattern in the MAINTAINERS file:

$ ./scripts/checkpatch.pl --show-types -f MAINTAINERS

results in 625 warnings of the following kind:

WARNING:REPEATED_WORD: Possible repeated word: 'git'
#XYZ: FILE: MAINTAINERS:XYZ:
+T:	git git://...

That pattern above is of course intentional and perfectly fine, so now the 
REPEATED_WORD check should not complain here.


Joe, would you accept a suitable refinement of the REPEATED_WORD check 
that address the issue above?

Dwaipayan, is that another good issue for you to look into and improve?
There are multiple ways to handle it either directly checking for that 
pattern or excluding MAINTAINERS or both or something completely 
different.


Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

             reply	other threads:[~2020-10-08 11:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 11:50 Lukas Bulwahn [this message]
2020-10-08 12:48 ` Joe Perches
2020-10-08 13:35   ` Dwaipayan Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2010081247510.19461@felia \
    --to=lukas.bulwahn@gmail.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [Linux-kernel-mentees] checkpatch.pl: REPEATED_WORD: massive false positive in MAINTAINERS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox