From: Arpitha Raghunandan <98.arpi@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: brendanhiggins@google.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
kunit-dev@googlegroups.com
Subject: Re: [Linux-kernel-mentees] [PATCH] lib: Convert test_hexdump.c to KUnit
Date: Sun, 9 Aug 2020 20:41:24 +0530 [thread overview]
Message-ID: <caf314b0-c090-26e6-3593-cb23aab1cbe3@gmail.com> (raw)
In-Reply-To: <20200806100540.GE3703480@smile.fi.intel.com>
On 06/08/20 3:35 pm, Andy Shevchenko wrote:
> On Thu, Aug 06, 2020 at 03:14:40PM +0530, Arpitha Raghunandan wrote:
>> Converts test lib/test_hexdump.c to KUnit.
>> More information about KUnit can be found at
>> https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html.
>> KUnit provides a common framework for unit tests in the kernel.
>
> ...
>
>> - if (memcmp(test, real, TEST_HEXDUMP_BUF_SIZE)) {
>> - pr_err("Len: %zu row: %d group: %d\n", len, rowsize, groupsize);
>> - pr_err("Result: '%s'\n", real);
>> - pr_err("Expect: '%s'\n", test);
>> - failed_tests++;
>> - }
>> + KUNIT_EXPECT_EQ(kunittest, 0, memcmp(test, real, TEST_HEXDUMP_BUF_SIZE));
>
>
> Ah, can you explain how user will see now what is being expected and what is in
> reality in the buffer? I'm not gonna accept such changes without showing in
> explicitly that user is not going to suffer of this change.
>
I have sent another patch replacing KUNIT_EXPECT_EQ() with KUNIT_EXPECT_EQ_MSG() and KUNIT_EXPECT_NE() with KUNIT_EXPECT_NE_MSG(). These methods log what is being expected and what is in reality in the buffer in case of test failure similar to the original test.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-08-09 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 9:44 [Linux-kernel-mentees] [PATCH] lib: Convert test_hexdump.c to KUnit Arpitha Raghunandan
2020-08-06 9:52 ` Andy Shevchenko
2020-08-07 21:33 ` David Gow via Linux-kernel-mentees
2020-08-06 10:05 ` Andy Shevchenko
2020-08-09 15:11 ` Arpitha Raghunandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf314b0-c090-26e6-3593-cb23aab1cbe3@gmail.com \
--to=98.arpi@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).