* [net-next] net: smsc911x: Remove unused variables
@ 2020-09-08 3:49 Wei Xu
2020-09-09 2:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Xu @ 2020-09-08 3:49 UTC (permalink / raw)
To: netdev
Cc: davem, xuwei5, linuxarm, shameerali.kolothum.thodi,
jonathan.cameron, john.garry, salil.mehta, shiju.jose, jinying,
zhangyi.ac, liguozhu, tangkunshan, huangdaode, Steve Glendinning,
Jakub Kicinski, linux-kernel
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_rx_fastforward’:
drivers/net/ethernet/smsc/smsc911x.c:1199:16: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_eeprom_write_location’:
drivers/net/ethernet/smsc/smsc911x.c:2058:6: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Wei Xu <xuwei5@hisilicon.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index fc168f8..823d9a7 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -1196,9 +1196,8 @@ smsc911x_rx_fastforward(struct smsc911x_data *pdata, unsigned int pktwords)
SMSC_WARN(pdata, hw, "Timed out waiting for "
"RX FFWD to finish, RX_DP_CTRL: 0x%08X", val);
} else {
- unsigned int temp;
while (pktwords--)
- temp = smsc911x_reg_read(pdata, RX_DATA_FIFO);
+ smsc911x_reg_read(pdata, RX_DATA_FIFO);
}
}
@@ -2055,7 +2054,6 @@ static int smsc911x_eeprom_write_location(struct smsc911x_data *pdata,
u8 address, u8 data)
{
u32 op = E2P_CMD_EPC_CMD_ERASE_ | address;
- u32 temp;
int ret;
SMSC_TRACE(pdata, drv, "address 0x%x, data 0x%x", address, data);
@@ -2066,7 +2064,7 @@ static int smsc911x_eeprom_write_location(struct smsc911x_data *pdata,
smsc911x_reg_write(pdata, E2P_DATA, (u32)data);
/* Workaround for hardware read-after-write restriction */
- temp = smsc911x_reg_read(pdata, BYTE_TEST);
+ smsc911x_reg_read(pdata, BYTE_TEST);
ret = smsc911x_eeprom_send_cmd(pdata, op);
}
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next] net: smsc911x: Remove unused variables
2020-09-08 3:49 [net-next] net: smsc911x: Remove unused variables Wei Xu
@ 2020-09-09 2:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-09 2:53 UTC (permalink / raw)
To: xuwei5
Cc: netdev, linuxarm, shameerali.kolothum.thodi, jonathan.cameron,
john.garry, salil.mehta, shiju.jose, jinying, zhangyi.ac,
liguozhu, tangkunshan, huangdaode, steve.glendinning, kuba,
linux-kernel
From: Wei Xu <xuwei5@hisilicon.com>
Date: Tue, 8 Sep 2020 11:49:25 +0800
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_rx_fastforward’:
> drivers/net/ethernet/smsc/smsc911x.c:1199:16: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_eeprom_write_location’:
> drivers/net/ethernet/smsc/smsc911x.c:2058:6: warning: variable ‘temp’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Wei Xu <xuwei5@hisilicon.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 3:49 [net-next] net: smsc911x: Remove unused variables Wei Xu
2020-09-09 2:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).