* [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines
@ 2007-01-04 4:39 ahendry
2007-01-04 10:29 ` Alan
2007-01-05 1:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: ahendry @ 2007-01-04 4:39 UTC (permalink / raw)
To: linux-x25, eis; +Cc: linux-kernel, netdev
Trivial. Newlines missing on the SOCK_DEBUG's for X.25 facility negotiation.
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
--- linux-2.6.19-vanilla/net/x25/x25_facilities.c 2006-12-31 22:31:07.000000000 +1100
+++ linux-2.6.19/net/x25/x25_facilities.c 2007-01-01 22:56:17.000000000 +1100
@@ -254,7 +254,7 @@ int x25_negotiate_facilities(struct sk_b
* They want reverse charging, we won't accept it.
*/
if ((theirs.reverse & 0x01 ) && (ours->reverse & 0x01)) {
- SOCK_DEBUG(sk, "X.25: rejecting reverse charging request");
+ SOCK_DEBUG(sk, "X.25: rejecting reverse charging request\n");
return -1;
}
@@ -262,29 +262,29 @@ int x25_negotiate_facilities(struct sk_b
if (theirs.throughput) {
if (theirs.throughput < ours->throughput) {
- SOCK_DEBUG(sk, "X.25: throughput negotiated down");
+ SOCK_DEBUG(sk, "X.25: throughput negotiated down\n");
new->throughput = theirs.throughput;
}
}
if (theirs.pacsize_in && theirs.pacsize_out) {
if (theirs.pacsize_in < ours->pacsize_in) {
- SOCK_DEBUG(sk, "X.25: packet size inwards negotiated down");
+ SOCK_DEBUG(sk, "X.25: packet size inwards negotiated down\n");
new->pacsize_in = theirs.pacsize_in;
}
if (theirs.pacsize_out < ours->pacsize_out) {
- SOCK_DEBUG(sk, "X.25: packet size outwards negotiated down");
+ SOCK_DEBUG(sk, "X.25: packet size outwards negotiated down\n");
new->pacsize_out = theirs.pacsize_out;
}
}
if (theirs.winsize_in && theirs.winsize_out) {
if (theirs.winsize_in < ours->winsize_in) {
- SOCK_DEBUG(sk, "X.25: window size inwards negotiated down");
+ SOCK_DEBUG(sk, "X.25: window size inwards negotiated down\n");
new->winsize_in = theirs.winsize_in;
}
if (theirs.winsize_out < ours->winsize_out) {
- SOCK_DEBUG(sk, "X.25: window size outwards negotiated down");
+ SOCK_DEBUG(sk, "X.25: window size outwards negotiated down\n");
new->winsize_out = theirs.winsize_out;
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines
2007-01-04 4:39 [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines ahendry
@ 2007-01-04 10:29 ` Alan
2007-01-05 1:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alan @ 2007-01-04 10:29 UTC (permalink / raw)
To: ahendry; +Cc: linux-x25, eis, linux-kernel, netdev
On Thu, 04 Jan 2007 15:39:24 +1100
ahendry <ahendry@tusc.com.au> wrote:
> Trivial. Newlines missing on the SOCK_DEBUG's for X.25 facility negotiation.
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines
2007-01-04 4:39 [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines ahendry
2007-01-04 10:29 ` Alan
@ 2007-01-05 1:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-01-05 1:01 UTC (permalink / raw)
To: ahendry; +Cc: linux-x25, eis, linux-kernel, netdev
From: ahendry <ahendry@tusc.com.au>
Date: Thu, 04 Jan 2007 15:39:24 +1100
> Trivial. Newlines missing on the SOCK_DEBUG's for X.25 facility negotiation.
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied, thanks Andrew.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-01-05 1:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-01-04 4:39 [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines ahendry
2007-01-04 10:29 ` Alan
2007-01-05 1:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).