Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors

From: Dave Jones <davej@codemonkey.org.uk>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	Pierre Ossman <drzeus-list@drzeus.cx>,
	LKML <linux-kernel@vger.kernel.org>,
	Adam Belay <abelay@novell.com>, Lee Revell <rlrevell@joe-job.com>,
	linux-pm@lists.linux-foundation.org
Subject: Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors
Date: Mon, 3 Mar 2008 23:00:48 -0500	[thread overview]
Message-ID: <20080304040048.GA31562@codemonkey.org.uk> (raw)
In-Reply-To: <20080303231033.GB15255@one.firstfloor.org>

On Tue, Mar 04, 2008 at 12:10:33AM +0100, Andi Kleen wrote:
 > On Mon, Mar 03, 2008 at 06:05:35PM -0500, Alan Stern wrote:
 > > On Mon, 3 Mar 2008, Pallipadi, Venkatesh wrote:
 > > 
 > > > But, with this patch:
 > > > - we are penalizing good hardware and making them less power efficient
 > > > to match the bad ones.
 > > > - There may also be server systems which first may not have these sort
 > > > of power fluctuations and even when buggy and have this noise, system
 > > > may be in some corner of some lab with fans making more noise than the
 > > > capacitors.
 > > 
 > > Can you make it configurable through sysfs?  
 > 
 > It already is, through a writable module_parm() 
 > 
 > > Default to disabled, but 
 > > allow the user to turn it on if the machine makes too much noise.
 > 
 > 99+% of the users wouldn't be able to figure that out.

99+% of users don't have singing capacitors. (Or don't care enough to complain)
For those that do can't figure out what to do from google,
we have a documentation problem.

	Dave 

-- 
http://www.codemonkey.org.uk