Re: [linux-pm] [PATCH] cpuidle: avoid singing capacitors

[Andi Kleen <andi@firstfloor.org>]

On Mon, Mar 03, 2008 at 11:00:48PM -0500, Dave Jones wrote:
> On Tue, Mar 04, 2008 at 12:10:33AM +0100, Andi Kleen wrote:
>  > On Mon, Mar 03, 2008 at 06:05:35PM -0500, Alan Stern wrote:
>  > > On Mon, 3 Mar 2008, Pallipadi, Venkatesh wrote:
>  > > 
>  > > > But, with this patch:
>  > > > - we are penalizing good hardware and making them less power efficient
>  > > > to match the bad ones.
>  > > > - There may also be server systems which first may not have these sort
>  > > > of power fluctuations and even when buggy and have this noise, system
>  > > > may be in some corner of some lab with fans making more noise than the
>  > > > capacitors.
>  > > 
>  > > Can you make it configurable through sysfs?  
>  > 
>  > It already is, through a writable module_parm() 
>  > 
>  > > Default to disabled, but 
>  > > allow the user to turn it on if the machine makes too much noise.
>  > 
>  > 99+% of the users wouldn't be able to figure that out.
> 
> 99+% of users don't have singing capacitors. (Or don't care enough to complain)
> For those that do can't figure out what to do from google,
> we have a documentation problem.

The big question is if there is a measurable difference in power consumption
from a reasonable default value.  I doubt it actually. The normal rule
of thumb is that if you average sleeps are long enough (and they still
stay this way even with the patch enabled) you're doing ok. If there is 
no or not significant penalty there is no reason to not enable it by default.

-Andi