linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: imx: fix imx8m dependencies
@ 2020-12-30 15:17 Arnd Bergmann
  2021-01-11  1:36 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-12-30 15:17 UTC (permalink / raw)
  To: Shawn Guo, Sascha Hauer, Peng Fan, Leonard Crestez
  Cc: arm, Arnd Bergmann, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, Anson Huang, linux-arm-kernel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Selecting ARM_GIC_V3 on non-CP15 processors leads to build failures
like

arch/arm/include/asm/arch_gicv3.h: In function 'write_ICC_AP1R3_EL1':
arch/arm/include/asm/arch_gicv3.h:36:40: error: 'c12' undeclared (first use in this function)
   36 | #define __ICC_AP1Rx(x)   __ACCESS_CP15(c12, 0, c9, x)
      |                                        ^~~

Add a dependency to only enable the gic driver when building for
at an ARMv7 target, which is the closes approximation to the ARMv8
processor that is actually in this chip.

Fixes: fc40200ebf82 ("soc: imx: increase build coverage for imx8m soc driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/imx/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index a9370f4aacca..05812f8ae734 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -13,7 +13,7 @@ config SOC_IMX8M
 	depends on ARCH_MXC || COMPILE_TEST
 	default ARCH_MXC && ARM64
 	select SOC_BUS
-	select ARM_GIC_V3 if ARCH_MXC
+	select ARM_GIC_V3 if ARCH_MXC && ARCH_MULTI_V7
 	help
 	  If you say yes here you get support for the NXP i.MX8M family
 	  support, it will provide the SoC info like SoC family,
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: imx: fix imx8m dependencies
  2020-12-30 15:17 [PATCH] ARM: imx: fix imx8m dependencies Arnd Bergmann
@ 2021-01-11  1:36 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-01-11  1:36 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Sascha Hauer, Peng Fan, Leonard Crestez, arm, Arnd Bergmann,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Anson Huang, linux-arm-kernel, linux-kernel

On Wed, Dec 30, 2020 at 04:17:51PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Selecting ARM_GIC_V3 on non-CP15 processors leads to build failures
> like
> 
> arch/arm/include/asm/arch_gicv3.h: In function 'write_ICC_AP1R3_EL1':
> arch/arm/include/asm/arch_gicv3.h:36:40: error: 'c12' undeclared (first use in this function)
>    36 | #define __ICC_AP1Rx(x)   __ACCESS_CP15(c12, 0, c9, x)
>       |                                        ^~~
> 
> Add a dependency to only enable the gic driver when building for
> at an ARMv7 target, which is the closes approximation to the ARMv8
> processor that is actually in this chip.
> 
> Fixes: fc40200ebf82 ("soc: imx: increase build coverage for imx8m soc driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-11  1:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 15:17 [PATCH] ARM: imx: fix imx8m dependencies Arnd Bergmann
2021-01-11  1:36 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).