Re: [PATCH] x86/perf: Use static_call for x86_pmu.guest_get_msrs

From: kernel test robot <lkp@intel.com>
To: Like Xu <like.xu@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Jason Baron <jbaron@akamai.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/perf: Use static_call for x86_pmu.guest_get_msrs
Date: Mon, 18 Jan 2021 20:12:35 +0800	[thread overview]
Message-ID: <202101182008.jQybUDa0-lkp@intel.com> (raw)
In-Reply-To: <20210118072151.44481-1-like.xu@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2557 bytes --]

Hi Like,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v5.11-rc4 next-20210118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Like-Xu/x86-perf-Use-static_call-for-x86_pmu-guest_get_msrs/20210118-153219
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 9a7832ce3d920426a36cdd78eda4b3568d4d09e3
config: x86_64-randconfig-a002-20210118 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 95d146182fdf2315e74943b93fb3bb0cbafc5d89)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/0cd2262fad043a5edef91fca07d16759703658b8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Like-Xu/x86-perf-Use-static_call-for-x86_pmu-guest_get_msrs/20210118-153219
        git checkout 0cd2262fad043a5edef91fca07d16759703658b8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/x86/events/core.c:670:31: error: redefinition of 'perf_guest_get_msrs'
   struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr)
                                 ^
   arch/x86/include/asm/perf_event.h:486:45: note: previous definition is here
   static inline struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr)
                                               ^
   1 error generated.

vim +/perf_guest_get_msrs +670 arch/x86/events/core.c

   669	
 > 670	struct perf_guest_switch_msr *perf_guest_get_msrs(int *nr)
   671	{
   672		struct perf_guest_switch_msr *ret = NULL;
   673	
   674		ret = static_call(x86_pmu_guest_get_msrs)(nr);
   675		if (!ret)
   676			*nr = 0;
   677	
   678		return ret;
   679	}
   680	EXPORT_SYMBOL_GPL(perf_guest_get_msrs);
   681	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32212 bytes --]