* [PATCH next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names
@ 2021-10-04 15:16 Krzysztof Kozlowski
2021-10-06 15:44 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-04 15:16 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Adrian Hunter, linux-mmc, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski, Rob Herring
The schema defines dependency only of clock-output-names on #clock-cells.
The dependency in opposite direction - requirement of clock-output-names
if #clock-cells is defined - should be explicitly included in the
bindings.
Reported-by: Rob Herring <robh@kernel.org>
Fixes: 22ea8ab0dcc4 ("dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Fixes tag from the linux-next
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
index dd70431df0b7..de6f076e0ece 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
@@ -158,6 +158,9 @@ properties:
description:
The MIO bank number in which the command and data lines are configured.
+dependencies:
+ '#clock-cells': [ clock-output-names ]
+
required:
- compatible
- reg
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names
2021-10-04 15:16 [PATCH next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names Krzysztof Kozlowski
@ 2021-10-06 15:44 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2021-10-06 15:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Adrian Hunter, linux-mmc, DTML,
Linux Kernel Mailing List, Rob Herring
On Mon, 4 Oct 2021 at 17:17, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> The schema defines dependency only of clock-output-names on #clock-cells.
> The dependency in opposite direction - requirement of clock-output-names
> if #clock-cells is defined - should be explicitly included in the
> bindings.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: 22ea8ab0dcc4 ("dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
Applied for next, thanks!
I took the liberty to squash this into the previous commit, and move
the reported-by tag into a reviewed-by tag from Rob.
Feel free to yell at me if there is something you don't like with the
squashed commit.
Kind regards
Uffe
> ---
>
> Fixes tag from the linux-next
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index dd70431df0b7..de6f076e0ece 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,6 +158,9 @@ properties:
> description:
> The MIO bank number in which the command and data lines are configured.
>
> +dependencies:
> + '#clock-cells': [ clock-output-names ]
> +
> required:
> - compatible
> - reg
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-06 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 15:16 [PATCH next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names Krzysztof Kozlowski
2021-10-06 15:44 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).