* [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type
@ 2023-05-15 15:37 Frank Li
2023-05-15 15:37 ` [PATCH v2 2/2] arm64: dts: imx8: fix USB 3.0 Gadget Failure in QM & QXPB0 at super speed Frank Li
2023-05-15 16:05 ` [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2023-05-15 15:37 UTC (permalink / raw)
To: shawnguo, Peter Chen, Pawel Laszczak, Roger Quadros,
Aswath Govindraju, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, open list:CADENCE USB3 DRD IP DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using
device_property_read_u16(). It resulted in 0 if a 32bit value was used
in dts. This commit fixes the dt binding doc to declare it as u16.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- new patch
Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
index cae46c4982ad..69a93a0722f0 100644
--- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
+++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
@@ -64,7 +64,7 @@ properties:
description:
size of memory intended as internal memory for endpoints
buffers expressed in KB
- $ref: /schemas/types.yaml#/definitions/uint32
+ $ref: /schemas/types.yaml#/definitions/uint16
cdns,phyrst-a-enable:
description: Enable resetting of PHY if Rx fail is detected
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] arm64: dts: imx8: fix USB 3.0 Gadget Failure in QM & QXPB0 at super speed
2023-05-15 15:37 [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Frank Li
@ 2023-05-15 15:37 ` Frank Li
2023-05-15 16:05 ` [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2023-05-15 15:37 UTC (permalink / raw)
To: shawnguo, Rob Herring, Krzysztof Kozlowski, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Greg Kroah-Hartman, Peter Chen,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list
Cc: imx
Resolve USB 3.0 gadget failure for QM and QXPB0 in super speed mode with
single IN and OUT endpoints, like mass storage devices, due to incorrect
ACTUAL_MEM_SIZE in ep_cap2 (32k instead of actual 18k). Implement dt
property cdns,on-chip-buff-size to override ep_cap2 and set it to 18k for
imx8QM and imx8QXP chips. No adverse effects for 8QXP C0.
Fixes: dce49449e04f ("usb: cdns3: allocate TX FIFO size according to composite EP number")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change from v1 to v2
- fixes warning from check-patch
- update dt-binding doc
arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
index b32c2e199c16..030c273c8be4 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi
@@ -171,6 +171,7 @@ usbotg3_cdns3: usb@5b120000 {
interrupt-names = "host", "peripheral", "otg", "wakeup";
phys = <&usb3_phy>;
phy-names = "cdns3,usb3-phy";
+ cdns,on-chip-buff-size = /bits/ 16 <18>;
status = "disabled";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type
2023-05-15 15:37 [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Frank Li
2023-05-15 15:37 ` [PATCH v2 2/2] arm64: dts: imx8: fix USB 3.0 Gadget Failure in QM & QXPB0 at super speed Frank Li
@ 2023-05-15 16:05 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-15 16:05 UTC (permalink / raw)
To: Frank Li, shawnguo, Peter Chen, Pawel Laszczak, Roger Quadros,
Aswath Govindraju, Greg Kroah-Hartman, Rob Herring,
Krzysztof Kozlowski, open list:CADENCE USB3 DRD IP DRIVER,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 15/05/2023 17:37, Frank Li wrote:
> In cdns3-gadget.c, 'cdns,on-chip-buff-size' was read using
> device_property_read_u16(). It resulted in 0 if a 32bit value was used
> in dts. This commit fixes the dt binding doc to declare it as u16.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - new patch
This needs fixes tag and Cc stable.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-15 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-15 15:37 [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Frank Li
2023-05-15 15:37 ` [PATCH v2 2/2] arm64: dts: imx8: fix USB 3.0 Gadget Failure in QM & QXPB0 at super speed Frank Li
2023-05-15 16:05 ` [PATCH v2 1/2] dt-binding: cdns,usb3: Fix cdns,on-chip-buff-size type Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).