Re: [PATCH 0/6] Minor cleanups & fixes for perf-probe(1)

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2010/12/20 23:17), Franck Bui-Huu wrote:
> From: Franck Bui-Huu <fbuihuu@gmail.com>
> 
> Hi,
> 
> This small patchset is just some random cosmetic cleanups I did when
> starting to read perf-probe(1) stuffs.

Hi Franck,

Basically the contains of this series are good to me.
(I've sent my comments)
however, it's less comments on each patch. Please explain
what you did in each patch! (not only on the subject line:-))

Thank you,

> 
> The 3 last patches of this serie are minor fixes though.
> 
> ---
> 
> Franck Bui-Huu (6):
>   perf-tools: make perf-probe -L display the absolute path of the dumped file
>   perf-probe: rewrite show_one_line() to make it simpler
>   perf-probe: clean up redundant tests in show_line_range()
>   perf-probe: Fix line range description since a single file is allowed
>   perf-probe: don't always consider EOF as an error when listing source code
>   perf-probe: handle gracefully some stupid and buggy line syntaxes
> 
>  tools/perf/Documentation/perf-probe.txt |    2 +-
>  tools/perf/util/probe-event.c           |  190 +++++++++++++++++++------------
>  2 files changed, 117 insertions(+), 75 deletions(-)
> 


-- 
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com