linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Franck Bui-Huu <fbuihuu@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
	mingo@redhat.com, masami.hiramatsu.pt@hitachi.com,
	fbuihuu@gmail.com, tglx@linutronix.de
Subject: [tip:perf/core] perf probe: Make -L display the absolute path of the dumped file
Date: Wed, 22 Dec 2010 11:30:31 GMT	[thread overview]
Message-ID: <tip-62c15fc49bd1b35d79b34ea96f132ab435e2215a@git.kernel.org> (raw)
In-Reply-To: <1292854685-8230-2-git-send-email-fbuihuu@gmail.com>

Commit-ID:  62c15fc49bd1b35d79b34ea96f132ab435e2215a
Gitweb:     http://git.kernel.org/tip/62c15fc49bd1b35d79b34ea96f132ab435e2215a
Author:     Franck Bui-Huu <fbuihuu@gmail.com>
AuthorDate: Mon, 20 Dec 2010 15:18:00 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 21 Dec 2010 16:20:11 -0200

perf probe: Make -L display the absolute path of the dumped file

The actual file used by 'perf probe -L sched.c' is reported in the ouput
of the command.

But it's simply displayed as it has been given to the command (simply
sched.c) which is too ambiguous to be really usefull since several
sched.c files can be found into the same project and we also don't know
which search path has been used.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
LKML-Reference: <1292854685-8230-2-git-send-email-fbuihuu@gmail.com>
Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/probe-event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 089d78e..0163fc0 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -371,7 +371,7 @@ int show_line_range(struct line_range *lr, const char *module)
 		fprintf(stdout, "<%s:%d>\n", lr->function,
 			lr->start - lr->offset);
 	else
-		fprintf(stdout, "<%s:%d>\n", lr->file, lr->start);
+		fprintf(stdout, "<%s:%d>\n", lr->path, lr->start);
 
 	fp = fopen(lr->path, "r");
 	if (fp == NULL) {

  parent reply	other threads:[~2010-12-22 11:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 14:17 [PATCH 0/6] Minor cleanups & fixes for perf-probe(1) Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 1/6] perf-tools: make perf-probe -L display the absolute path of the dumped file Franck Bui-Huu
2010-12-21  5:30   ` Masami Hiramatsu
2010-12-22 11:30   ` tip-bot for Franck Bui-Huu [this message]
2010-12-20 14:18 ` [PATCH 2/6] perf-probe: rewrite show_one_line() to make it simpler Franck Bui-Huu
2010-12-21  8:55   ` Masami Hiramatsu
2010-12-22 11:30   ` [tip:perf/core] perf probe: Rewrite " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 3/6] perf-probe: clean up redundant tests in show_line_range() Franck Bui-Huu
2010-12-21  9:47   ` Masami Hiramatsu
2010-12-22 11:31   ` [tip:perf/core] perf probe: Clean " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 4/6] perf-probe: Fix line range description since a single file is allowed Franck Bui-Huu
2010-12-22 11:31   ` [tip:perf/core] perf probe: " tip-bot for Franck Bui-Huu
2010-12-20 14:18 ` [PATCH 5/6] perf-probe: don't always consider EOF as an error when listing source code Franck Bui-Huu
2010-12-21 11:54   ` Masami Hiramatsu
2010-12-22 11:31   ` [tip:perf/core] perf probe: Don't " tip-bot for Franck Bui-Huu
2010-12-22 13:14     ` Franck Bui-Huu
2010-12-22 14:43       ` Arnaldo Carvalho de Melo
2010-12-22 16:37         ` Franck Bui-Huu
2010-12-25  8:58           ` [tip:perf/core] perf probe: Fix wrong warning in __show_one_line() if read(1) errors happen tip-bot for Franck Bui-Huu
2010-12-26 14:11             ` Masami Hiramatsu
2010-12-20 14:18 ` [PATCH 6/6] perf-probe: handle gracefully some stupid and buggy line syntaxes Franck Bui-Huu
2010-12-21 13:10   ` Masami Hiramatsu
2010-12-22 11:32   ` [tip:perf/core] perf probe: Handle " tip-bot for Franck Bui-Huu
2010-12-21 13:11 ` [PATCH 0/6] Minor cleanups & fixes for perf-probe(1) Masami Hiramatsu
2010-12-21 18:01   ` Franck Bui-Huu
2010-12-21 21:05     ` Arnaldo Carvalho de Melo
2010-12-22 13:11       ` Franck Bui-Huu
2010-12-24  0:36         ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-62c15fc49bd1b35d79b34ea96f132ab435e2215a@git.kernel.org \
    --to=fbuihuu@gmail.com \
    --cc=acme@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).