From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Greg KH" <greg@kroah.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 pci: remove checking type for mmconfig probe v2
Date: Sat, 1 Mar 2008 00:36:50 -0800 [thread overview]
Message-ID: <86802c440803010036u2cb89a30h2adb90b3ee497cfc@mail.gmail.com> (raw)
In-Reply-To: <20080301060236.GE20032@kroah.com>
On Fri, Feb 29, 2008 at 10:02 PM, Greg KH <greg@kroah.com> wrote:
> On Thu, Feb 28, 2008 at 11:56:50PM -0800, Yinghai Lu wrote:
> >
> > doesn't need to check if it is type1 or type2. we can use raw_pci_ops dirctly.
>
> Why? is this because the ops are already set up? It would be nice to
> add the "why this change is necessary and/or possible now" for the
> changelog.
yes.
raw_pci_ops got assigned when check direct_type1 and direct_type2.
and could used in hostbridge check to get MMCONF base.
make mmconfig probe clean
with checking if raw_pci_ops is assigned instead of passing type or
checking type.
YH
next prev parent reply other threads:[~2008-03-01 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 0:39 [PATCH] x86 pci: remove checking type for mmconfig probe Yinghai Lu
2008-02-29 7:56 ` [PATCH] x86 pci: remove checking type for mmconfig probe v2 Yinghai Lu
2008-02-29 19:17 ` Ingo Molnar
2008-02-29 19:21 ` H. Peter Anvin
2008-03-01 6:02 ` Greg KH
2008-03-01 8:36 ` Yinghai Lu [this message]
2008-03-04 6:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440803010036u2cb89a30h2adb90b3ee497cfc@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).