linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi all,

In commit

  99d53ba0d0d9 ("platform/x86: hp-wmi: Don't log a warning on HPWMI_RET_UNKNOWN_COMMAND errors")

Fixes tag

  Fixes: 81c93798ef3e ("platform/x86: hp-wmi: add support for thermal policy

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi all,

On Tue, 19 Jan 2021 06:27:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   99d53ba0d0d9 ("platform/x86: hp-wmi: Don't log a warning on HPWMI_RET_UNKNOWN_COMMAND errors")
> 
> Fixes tag
> 
>   Fixes: 81c93798ef3e ("platform/x86: hp-wmi: add support for thermal policy
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes

This is also commit

  b96705325421 ("platform/x86: hp-wmi: Don't log a warning on HPWMI_RET_UNKNOWN_COMMAND errors")

in the drivers-x86 tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

[Hans de Goede]

Hi,

On 1/18/21 8:39 PM, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 19 Jan 2021 06:27:58 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> In commit
>>
>>   99d53ba0d0d9 ("platform/x86: hp-wmi: Don't log a warning on HPWMI_RET_UNKNOWN_COMMAND errors")
>>
>> Fixes tag
>>
>>   Fixes: 81c93798ef3e ("platform/x86: hp-wmi: add support for thermal policy
>>
>> has these problem(s):
>>
>>   - Subject has leading but no trailing parentheses
>>   - Subject has leading but no trailing quotes
> 
> This is also commit
> 
>   b96705325421 ("platform/x86: hp-wmi: Don't log a warning on HPWMI_RET_UNKNOWN_COMMAND errors")
> 
> in the drivers-x86 tree.

Sorry about that, I've fixed it in both the drivers-x86-fixes and the regular
drivers-x86 trees.

Strange enough checkpatch does not catch this, while it does catch misformatted
commit references in the non tags part of the commit message. I will mail the
checkpatch maintainer about this.

Regards,

Hans

Re: linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

[Hans de Goede]

Hi,

On 4/4/22 23:50, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   753ee989f7cf ("platform/x86: amd-pmc: Fix compilation without CONFIG_SUSPEND")
> 
> Fixes tag
> 
>   Fixes: commit b1f66033cd4e ("platform/x86: amd-pmc: Move to later in the suspend process")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Stephen, thank you for the report. I've just done a forced push
to the drivers-x86-fixes branch fixing this.

Regards,

Hans

linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Hi all,

In commit

  753ee989f7cf ("platform/x86: amd-pmc: Fix compilation without CONFIG_SUSPEND")

Fixes tag

  Fixes: commit b1f66033cd4e ("platform/x86: amd-pmc: Move to later in the suspend process")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the drivers-x86-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi all,

In commit

  57f634b76a95 ("platform/x86: dell-laptop: fix rfkill functionality")

Fixes tag

  Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]