* [PATCH] irqdomain: Export __irq_domain_alloc_irqs() to modules
@ 2021-10-04 15:05 Marc Zyngier
2021-10-04 15:59 ` Lorenzo Pieralisi
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2021-10-04 15:05 UTC (permalink / raw)
To: linux-kernel, linux-pci; +Cc: Lorenzo Pieralisi, Thomas Gleixner
The Apple PCIe controller driver allocates interrupts generated
by the PCIe ports, and uses irq_domain_alloc_irqs() for that.
THis is an inline function that uses __irq_domain_alloc_irqs()
as a backend.
Since the driver can be built as a module, __irq_domain_alloc_irqs()
must be exported.
Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support")
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
Notes:
Since the offending code is only in the PCI tree so far,
it would make sense if Lorenzo could take this patch directly.
kernel/irq/irqdomain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 5a698c1f6cc6..40e85a46f913 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -1502,6 +1502,7 @@ int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base,
irq_free_descs(virq, nr_irqs);
return ret;
}
+EXPORT_SYMBOL_GPL(__irq_domain_alloc_irqs);
/* The irq_data was moved, fix the revmap to refer to the new location */
static void irq_domain_fix_revmap(struct irq_data *d)
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqdomain: Export __irq_domain_alloc_irqs() to modules
2021-10-04 15:05 [PATCH] irqdomain: Export __irq_domain_alloc_irqs() to modules Marc Zyngier
@ 2021-10-04 15:59 ` Lorenzo Pieralisi
2021-10-04 16:07 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-04 15:59 UTC (permalink / raw)
To: Marc Zyngier; +Cc: linux-kernel, linux-pci, Thomas Gleixner
On Mon, Oct 04, 2021 at 04:05:52PM +0100, Marc Zyngier wrote:
> The Apple PCIe controller driver allocates interrupts generated
> by the PCIe ports, and uses irq_domain_alloc_irqs() for that.
> THis is an inline function that uses __irq_domain_alloc_irqs()
> as a backend.
>
> Since the driver can be built as a module, __irq_domain_alloc_irqs()
> must be exported.
>
> Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support")
I have squashed this patch into the commit it is fixing and pushed
pci/apple out.
I could have merged it as a standalone patch before the commit it is
fixing but it would not make sense on its own I believe, happy to
rectify the branch in case that's preferred.
Lorenzo
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
>
> Notes:
> Since the offending code is only in the PCI tree so far,
> it would make sense if Lorenzo could take this patch directly.
>
> kernel/irq/irqdomain.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 5a698c1f6cc6..40e85a46f913 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -1502,6 +1502,7 @@ int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base,
> irq_free_descs(virq, nr_irqs);
> return ret;
> }
> +EXPORT_SYMBOL_GPL(__irq_domain_alloc_irqs);
>
> /* The irq_data was moved, fix the revmap to refer to the new location */
> static void irq_domain_fix_revmap(struct irq_data *d)
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqdomain: Export __irq_domain_alloc_irqs() to modules
2021-10-04 15:59 ` Lorenzo Pieralisi
@ 2021-10-04 16:07 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2021-10-04 16:07 UTC (permalink / raw)
To: Lorenzo Pieralisi; +Cc: linux-kernel, linux-pci, Thomas Gleixner
On Mon, 04 Oct 2021 16:59:15 +0100,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
>
> On Mon, Oct 04, 2021 at 04:05:52PM +0100, Marc Zyngier wrote:
> > The Apple PCIe controller driver allocates interrupts generated
> > by the PCIe ports, and uses irq_domain_alloc_irqs() for that.
> > THis is an inline function that uses __irq_domain_alloc_irqs()
> > as a backend.
> >
> > Since the driver can be built as a module, __irq_domain_alloc_irqs()
> > must be exported.
> >
> > Fixes: 201adeaa9d82 ("PCI: apple: Add INTx and per-port interrupt support")
>
> I have squashed this patch into the commit it is fixing and pushed
> pci/apple out.
>
> I could have merged it as a standalone patch before the commit it is
> fixing but it would not make sense on its own I believe, happy to
> rectify the branch in case that's preferred.
The final patch has links to both patches on the list, so that's
absolutely fine by me.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 15:05 [PATCH] irqdomain: Export __irq_domain_alloc_irqs() to modules Marc Zyngier
2021-10-04 15:59 ` Lorenzo Pieralisi
2021-10-04 16:07 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).