* [PATCH] [v3] block: Fix an error handling in add_partition
@ 2021-01-17 8:53 Dinghao Liu
2021-01-18 11:37 ` Jan Kara
2021-01-19 4:48 ` Chaitanya Kulkarni
0 siblings, 2 replies; 3+ messages in thread
From: Dinghao Liu @ 2021-01-17 8:53 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Jens Axboe, Jan Kara, Hannes Reinecke, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
Changelog:
v2: - Refine commit message.
v3: - Add '[v3]' to the title.
---
block/partitions/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/partitions/core.c b/block/partitions/core.c
index e7d776db803b..23460cee9de5 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,
err = blk_alloc_devt(bdev, &devt);
if (err)
- goto out_bdput;
+ goto out_put;
pdev->devt = devt;
/* delay uevent until 'holders' subdir is created */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [v3] block: Fix an error handling in add_partition
2021-01-17 8:53 [PATCH] [v3] block: Fix an error handling in add_partition Dinghao Liu
@ 2021-01-18 11:37 ` Jan Kara
2021-01-19 4:48 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2021-01-18 11:37 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Jens Axboe, Jan Kara, Hannes Reinecke, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
On Sun 17-01-21 16:53:42, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
>
> Changelog:
>
> v2: - Refine commit message.
>
> v3: - Add '[v3]' to the title.
> ---
> block/partitions/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index e7d776db803b..23460cee9de5 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,
>
> err = blk_alloc_devt(bdev, &devt);
> if (err)
> - goto out_bdput;
> + goto out_put;
> pdev->devt = devt;
>
> /* delay uevent until 'holders' subdir is created */
> --
> 2.17.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v3] block: Fix an error handling in add_partition
2021-01-17 8:53 [PATCH] [v3] block: Fix an error handling in add_partition Dinghao Liu
2021-01-18 11:37 ` Jan Kara
@ 2021-01-19 4:48 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2021-01-19 4:48 UTC (permalink / raw)
To: Dinghao Liu, kjlu
Cc: Jens Axboe, Jan Kara, Hannes Reinecke, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
On 1/17/21 1:00 AM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-19 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-17 8:53 [PATCH] [v3] block: Fix an error handling in add_partition Dinghao Liu
2021-01-18 11:37 ` Jan Kara
2021-01-19 4:48 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).